Conversation
Collaborator
Author
|
I'm going to break this up into 3 separate PRs to keep the reviews lightweight and manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clears up the
heading-order, andlink-name,landmark-uniqueaccessibility violations from a11y page tests:<h5>, breaking document outlines. Converted them to<p class="callout-title">withrole="note"on the container so visual styling stays identical while removing them from the heading structure./reference/#), creating invisible tab stops and triggering link-name failures. We now only render these links when a submodule actually exists.srcdocpreview frames generated by p5 were causing duplicate landmark warnings (<main>and canvas regions). Excluded frame contents from the scan scope while keeping iframe elements in scope.