Skip to content

feat: add underline to links within text#1528

Open
coseeian wants to merge 1 commit into
processing:mainfrom
coseeian:underline
Open

feat: add underline to links within text#1528
coseeian wants to merge 1 commit into
processing:mainfrom
coseeian:underline

Conversation

@coseeian

@coseeian coseeian commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

To address: #1505 .

Summary

  • styles/markdown.scss: add persistent text-decoration: underline to prose links inside .rendered-markdown, scoped as a:not(.button-link) so styled button links are excluded.

@limzykenneth

Copy link
Copy Markdown
Member

They are mostly there but there are some false negatives:

These probably should be underlined as well.
Screenshot 2026-07-22 at 12 00 28

These in community sketches too perhaps
Screenshot 2026-07-22 at 12 03 11

Should these be underlined too?
Screenshot 2026-07-22 at 12 04 04

I wonder if there is somewhere in the CSS rules that applies the p5 magenta highlight we can add the underline rule at the same place then we'll catch more or less the places we want to have underlines? Unless that introduce too many false positives.

@coseeian

Copy link
Copy Markdown
Collaborator Author

Let me take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants