sass: Migrate from deprecated @import to @use#1313
Draft
nbogie wants to merge 2 commits intoprocessing:2.0from
Draft
sass: Migrate from deprecated @import to @use#1313nbogie wants to merge 2 commits intoprocessing:2.0from
nbogie wants to merge 2 commits intoprocessing:2.0from
Conversation
Also, assume project root dir is in load path, remove leading / However, see differences from @import https://sass-lang.com/documentation/at-rules/use/#differences-from-import
a937b17 to
61865ef
Compare
Member
|
Full namespace is fine as it is not very significant. Let me know when you are ready with this one and I can check locally as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1309
Changes:
@importto@usee.g.
/styles/variables.scsstostyles/variables.scss@import(an accidental regression) will break the build with appropriate message.status:
Working locally, but I'll do some more build and deployment testing (esp through CI) to check the generated css (e.g. for duplication) and to check for issues on our CI platform.
discussion (opinions)
While it's possible to rename the namespace when using
@use,So instead of:
We could write:
but I suggest sticking with the full namespace (in this case
variables) is less surprising, more self-descriptive, easier for find/find-replace, and not too long.(Anyway, that can be decided and changed going fwd.)