fix: enable OpenProcessing sketch embeds on detail pages#1310
Open
rushdarshan wants to merge 3 commits intoprocessing:mainfrom
Open
fix: enable OpenProcessing sketch embeds on detail pages#1310rushdarshan wants to merge 3 commits intoprocessing:mainfrom
rushdarshan wants to merge 3 commits intoprocessing:mainfrom
Conversation
Fixes processing#674 The regex in normalizeP5ReferenceLinks() was capturing the 'p5' prefix in the capture group, causing duplicate 'p5' in URLs. Before: #/p5/rectMode -> /reference/p5/p5/rectMode/ (broken) After: #/p5/rectMode -> /reference/p5/rectMode/ (fixed) Updated regex to exclude 'p5' from capture group while still handling both dot notation (#/p5.Element) and slash notation (#/p5/rectMode) patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenProcessing sketch embeds on sketch detail pages failing to render due to missing iframe security attributes.
Root Cause
iframe elements lacked \sandbox\ and \�llow\ attributes, blocking OpenProcessing embed scripts from executing.
Solution
Added proper iframe security and permission attributes:
Files Changed
Testing
Verified both code paths render with proper attributes on sketch detail pages.