Skip to content

Add Chinese translation for organizing-code-with-functions.mdx#1302

Open
Chiuye wants to merge 5 commits intoprocessing:mainfrom
Chiuye:translate/organizing-code-with-functions
Open

Add Chinese translation for organizing-code-with-functions.mdx#1302
Chiuye wants to merge 5 commits intoprocessing:mainfrom
Chiuye:translate/organizing-code-with-functions

Conversation

@Chiuye
Copy link
Copy Markdown

@Chiuye Chiuye commented Apr 5, 2026

Summary

This PR adds a full Chinese (zh-CN) translation of the Organizing Code with Functions tutorial.

Notes

(Waiting to link to a new issue?)

@Chiuye
Copy link
Copy Markdown
Author

Chiuye commented Apr 5, 2026

@lirenjie95 Hi, sorry I'm a newcomer contributing to an open-source GitHub project for the first time, so I might not be familiar with some aspects. 😥😣
I tried creating a new branch in my forked repository and submitting a PR with commits from that branch. Is that the right way to do it?
Besides, I'm not quite sure how to create an issue. Should I put all language translations of the "Organizing Code with Functions" tutorial in one issue, or just the Chinese version I'm currently translating? And is there a fixed template or format for creating translation-related issues? Since I'm uncertain, I haven't created a new issue yet.
Could you please help check? I would greatly appreciate it. 😣🙏

@Chiuye Chiuye changed the title Add Chinese translation Add Chinese translation for organizing-code-with-functions.mdx Apr 5, 2026
Copy link
Copy Markdown
Contributor

@lirenjie95 lirenjie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Chiuye, thanks for your contribution! The translation looks great overall. I've noted a few places that read a bit awkward for your reference.
Regarding the issue attached to this PR — it's required for the main p5.js repo, though I didn't see it as a strict requirement for p5.js-website. Let's leave it as is. Feel free to tag the maintainer for merging once I've approved your new changes.

@ksen0
Copy link
Copy Markdown
Member

ksen0 commented Apr 7, 2026

Hi @Chiuye and welcome! In general, we do prefer that there's an issue before a PR, but of course we consider on a case by case basis. No worries.

@Divyansh013 is the i18n steward overall and can be tagged too. I think we are focusing now on the more basic tutorials, but since this translation has already been proposed and reviewed, I think it is fine to merge it when it's done. But if it should wait fo something, or if it duplicates any work, please let us know @Divyansh013

Copy link
Copy Markdown
Contributor

@lirenjie95 lirenjie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, approved!

@Chiuye
Copy link
Copy Markdown
Author

Chiuye commented Apr 8, 2026

Hi @lirenjie95, I've updated the translation following your feedback and added a few changes based on my own understanding. Could you please review it again?🥰
Additionally, I found a small issue (see line 680 in Chinese version): the comment line above the trees() function says "draw two trees", but instead there are three trees in the trees() function. I have opened issue #1319 for this. @ksen0

@ksen0 ksen0 requested a review from doradocodes April 8, 2026 10:16
@ksen0
Copy link
Copy Markdown
Member

ksen0 commented Apr 8, 2026

Looks good to me! Tagging @doradocodes to merge when you're next doing triage, and to determine whether cherrypicking to 2.0 is applicable here, I think this tutorial is the same in the 2 site versions but I'm not 100% sure

@Chiuye Chiuye force-pushed the translate/organizing-code-with-functions branch from 8a29cd7 to e9e8b53 Compare April 9, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants