add UI to toggle loop protection via <!-- noprotect -->#4108
Open
skyash-dev wants to merge 3 commits into
Open
add UI to toggle loop protection via <!-- noprotect -->#4108skyash-dev wants to merge 3 commits into
skyash-dev wants to merge 3 commits into
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
davepagurek
reviewed
May 10, 2026
davepagurek
reviewed
May 10, 2026
davepagurek
reviewed
May 10, 2026
Author
Contributor
|
I think we're good to go ahead with the comment living in index.html -- possibly a bit unexpected for users of other tools, but then it's in one spot, and people mostly will use the UI anyway. For padding/margins, maybe make a separate issue/PR? It's always a little weird doing design updates since often these are fairly subjective and could use a bit of feedback, so we don't need to block this PR on those updates. |
66329bf to
32acd1e
Compare
Author
|
hi @davepagurek! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue:
Fixes #4081
Adds a UI control for enabling/disabling loop protection from Preferences.
This implementation treats
<!-- noprotect -->inindex.htmlas the source of truth:<!-- noprotect -->inindex.htmlindex.htmlDemo:
Changes:
index.htmlindex.htmlnoprotect comment when toggled<!-- noprotect -->comment in syncI have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123