Skip to content

i18 sync#4089

Closed
Nishthajain7 wants to merge 1 commit into
processing:developfrom
Nishthajain7:i18-sync
Closed

i18 sync#4089
Nishthajain7 wants to merge 1 commit into
processing:developfrom
Nishthajain7:i18-sync

Conversation

@Nishthajain7
Copy link
Copy Markdown
Contributor

Issue:

Fixes #3510

Changes:

  • "SubmitSaveAllSettings": "Save All Settings" has been replaced with "SaveAccountDetails": "Save Account Details"
  • "Settings": "Account Settings" (under AccountView) has been updated to "Settings": "My Account"

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Copy link
Copy Markdown
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. For translation-related PRs, we only accept changes from native or fluent speakers of the respective language because we need to ensure the translations are accurate and natural. Since the team cannot reliably verify translations for every language, we request contributors to work only on languages they are fluent in.

@ksen0
Copy link
Copy Markdown
Member

ksen0 commented May 26, 2026

Thanks for the review @yugalkaushik . Thanks for the work @Nishthajain7 but I'll close this, as the policy is for fluent speakers to proposed translation changes, so 1 PR should only cover 1 language. This PR also makes some unexpected changes to keys.

@ksen0 ksen0 closed this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n Sync: Update Settings and SubmitSaveAllSettings Keys Across Locale Files

3 participants