Various new traits

[larowlan]

• SpinTrait for retrying in a test
• Extra random methods (url, email, location, address)
• Constraint violation asserts

[mstrelan]

Looks good, just a few nits. Also the other existing traits have README entries. It's a hassle though, do we think it's worthwhile?

[mstrelan]

I've always felt we should use example.com as the domain name. Turns out there is now a reserved .example TLD.

Suggested change

	/**
	* Generates a random URL.
	*
	* @return string
	* Random URL.
	*/
	protected function randomUrl(): string {
	$random = new Random();
	return \sprintf('https://%s.com/%s', $random->name(), $random->name());
	}
	/**
	* Generates a random URL.
	*
	* @return string
	* Random URL.
	*/
	protected function randomUrl(): string {
	$random = new Random();
	return \sprintf('https://%s.example/%s', $random->name(), $random->name());
	}

[mstrelan]

Suggested change

	return \sprintf('%s@%s.com', $random->name(), $random->name());
	return \sprintf('%s@%s.example', $random->name(), $random->name());

[mstrelan]

Nit: floats are not strings

Suggested change

	return \sprintf('POINT(%s %s)', $lon, $lat);
	return \sprintf('POINT(%.05n %.05n)', $lon, $lat);

[mstrelan]

Suggested change

	* Executes a callable until it returns TRUE.
	*
	* Executes executing a task until a condition is met.
	* Executes a callable until it returns TRUE.

[mstrelan]

Nit:

Suggested change

	* @param int $count
	* (optional) Number of times to try, defaults to 10.
	* @param bool $throw
	* (optional) Throw, TRUE to throw if the condition is not met.
	*
	* @return bool
	* TRUE if lambda evaluated true.
	*
	* @throws \Exception
	* When the condition is not met.
	*/
	protected function spin(callable $lambda, $count = 10, $throw = TRUE): bool {
	* @param non-negative-int $count
	* (optional) Number of times to try, defaults to 10.
	* @param bool $throw
	* (optional) Throw, TRUE to throw if the condition is not met.
	*
	* @return bool
	* TRUE if lambda evaluated true.
	*
	* @throws \Exception
	* When the condition is not met.
	*/
	protected function spin(callable $lambda, int $count = 10, bool $throw = TRUE): bool {

[mstrelan]

Non-capturing catch:

Suggested change

	catch (\Exception $e) {
	// Do nothing.
	}
	catch (\Exception) {
	// Do nothing.
	}

[mstrelan]

It would be nice to have a more specific exception, maybe \Behat\Mink\Exception\ExpectationException.

[mstrelan]

We could also require PHP 8.3 and use Randomizer::getFloat.