Simplify the reference-results-metadata file - #894
Open
MakisH wants to merge 6 commits into
Open
Conversation
MakisH
marked this pull request as ready for review
August 9, 2026 20:07
MakisH
commented
Aug 9, 2026
| shutil.copytree(exports_dir, exports_staging) | ||
| try: | ||
| (exports_staging / "reference-results-metadata.txt").write_text(metadata) | ||
| (exports_staging / "reference-results-metadata.md").write_text(metadata) |
Member
Author
There was a problem hiding this comment.
Actually, naming that .reference-results-metadata.md would place it at the top of the file list, at least for my archive manager. I can rename it tomorrow.
Collaborator
|
@MakisH looks good to me, and renaming to |
PranjalManhgaye
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current metadata file is named
reference-results-metadata.txt, but it is a Markdown file.Some information in that file is not particularly useful: once the host is known, the CPU information is automatically known, and reproducibility across systems is not intended.
There is currently a missing blank line:
This PR:
.txtto.mdlscpuoutput (first added in Add Workflows for generating reference results #410 (comment))get_machine_informations()toget_machine_information()Follow-up of #882.
Tested in https://github.com/precice/tutorials/actions/runs/31333057244, leads to: