Floxis: set gvl_id to 1609 - #6698
Open
floxis-admin wants to merge 1 commit into
Open
Conversation
The shipped Prebid.js adapter has declared gvlid 1609 since it merged, and IAB GVL vendor 1609 is registered to Ad Tech Company OU, but this page still reads gvl_id: none - so TCF publishers evaluating the adapter see it as having no registered vendor ID.
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Context on why I split this out instead of waiting for #6596 I know everyone is stretched and our adapter PRs sit here for months without anything happening, could you please merge at least this one. This one line is costing us real business: we're onboarding publishers now and several have stopped dead at I will rebase the other PRs. Please merge this at least... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line correction: this page reads
gvl_id: none, but the Floxis adapter has declaredgvlid: 1609since it merged (modules/floxisBidAdapter.json master, lines 7 and 171), and IAB GVL vendor 1609 is registered to Ad Tech Company OÜ (GVL v171).Raising it separately because publishers evaluating the adapter read this page as "no registered TCF vendor ID", which is a blocker for them.
The same line is corrected in #6596, but that PR also flips
pbs: trueand is held under Pending PBS Release while prebid/prebid-server#4811 is in review — so the fix is currently gated on something unrelated to it. This PR carries only thegvl_idline so it can land independently; I'll rebase #6596 on top once it merges.