Skip to content

RFC 3986 enabled by default #4581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 2 commits into from
Jul 30, 2026
+7 −5
Merged

RFC 3986 enabled by default #4581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7b9241
RFC 3986 enabled by default
osulzhenko Jul 30, 2026
681fd7b
update functional tests
osulzhenko Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/prebid/server/spring/config/SettingsConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ static class HttpSettingsConfiguration {

@Bean
HttpApplicationSettings httpApplicationSettings(
@Value("${settings.http.rfc3986-compatible:false}") boolean isRfc3986Compatible,
@Value("${settings.http.rfc3986-compatible:true}") boolean isRfc3986Compatible,
HttpClient httpClient,
JacksonMapper mapper,
@Value("${settings.http.endpoint}") String endpoint,
Expand Down
10 changes: 6 additions & 4 deletions src/test/groovy/org/prebid/server/functional/testcontainers/PbsConfig.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,11 @@ LIMIT 1
}

static Map<String, String> getHttpSettingsConfig(String rootUri = networkServiceContainer.rootUri) {
["settings.http.endpoint" : "$rootUri/stored-requests".toString(),
"settings.http.amp-endpoint" : "$rootUri/amp-stored-requests".toString(),
"settings.http.video-endpoint" : "$rootUri/video-stored-requests".toString(),
"settings.http.category-endpoint": "$rootUri/video-categories".toString()].asImmutable()
["settings.http.endpoint" : "$rootUri/stored-requests".toString(),
"settings.http.amp-endpoint" : "$rootUri/amp-stored-requests".toString(),
"settings.http.video-endpoint" : "$rootUri/video-stored-requests".toString(),
"settings.http.rfc3986-compatible": "false",
"settings.http.category-endpoint" : "$rootUri/video-categories".toString()].asImmutable()
}

static Map<String, String> getAdminEndpointConfig() {
Expand Down Expand Up @@ -101,6 +102,7 @@ LIMIT 1
"settings.database.idle-connection-timeout": "300"
].asImmutable()
}

static Map<String, String> getPostgreSqlConfig(PostgreSQLContainer postgres = Dependencies.postgresqlContainer) {
["settings.database.type" : "postgres",
"settings.database.host" : postgres.getNetworkAliases().get(0),
Expand Down
Loading