RTBHouse: Fix unintended site object creation for app requests#4531
Open
pjaworski-rtbh wants to merge 1 commit into
Open
RTBHouse: Fix unintended site object creation for app requests#4531pjaworski-rtbh wants to merge 1 commit into
pjaworski-rtbh wants to merge 1 commit into
Conversation
824fecd to
fef41e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
The RTBHouse bidder was unconditionally constructing a
siteobject on every outgoing request while attaching the publisher ID. For app-only requests (nositein the incoming Prebid Server request), this resulted in a syntheticsiteobject being added to the outbound bid request, even though only anappobject was present.📋 Description
Fixes publisher ID propagation so it no longer fabricates a
siteobject:modifySitenow only modifies an existingsiteand returnsnulluntouched — no syntheticsiteis created when the request has none.modifyApppropagates the publisher ID toapp.publisher.ext.prebid.publisherIdfor app traffic, mirroring the existingsite.publisherbehaviour.modifyPublisherhelper used by bothsiteandapp.🧪 Testing results
Tests run: 26, Failures: 0, Errors: 0, Skipped: 0All RTBHouse bidder tests pass, including new coverage:
makeHttpRequestsShouldNotCreateSiteWhenBidRequestHasAppOnly— verifies nositeis added for app-only requestsmakeHttpRequestsShouldAddPublisherToAppWhenBidRequestHasAppOnly— verifies publisher ID is propagated toapp.publisherOther information
Please reach us at inventory_support@rtbhouse.com with piotr.jaworski@rtbhouse.com and cc leandro.otani@rtbhouse.com.