Tests: Refactoring functional tests by osulzhenko · Pull Request #3657 · prebid/prebid-server-java

osulzhenko · 2025-01-06T08:07:20Z

🔧 Type of changes

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

verify email contact works
NO fully dynamic hostnames
geographic host parameters are NOT required
direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/AmpFpdSpec.groovy

osulzhenko · 2025-01-26T16:30:21Z

review is postponed

# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/module/AbTestingModuleSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/GeneralModuleSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/analyticstag/AnalyticsTagsModuleSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/ortb2blocking/Ortb2BlockingSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/richmedia/RichMediaFilterSpec.groovy

# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/ActivityTraceLogSpec.groovy

# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy

marki1an · 2025-03-31T13:53:09Z

+    private static PrebidServerService pbsServiceWithEnabledMediaFilter
+    private static PrebidServerService pbsServiceWithEnabledMediaFilterAndDifferentCaseStrategy
+
+


marki1an · 2025-11-14T07:15:38Z

+    private static final PrebidServerService disabledDebugPbsService = pbsServiceFactory.getService("adapters.generic.debug.allow": "false")
+
+    def cleanupSpec() {
+        pbsServiceFactory.removeContainer("adapters.generic.debug.allow": "true")


Please extract into a separate const variable "adapters.generic.debug.allow": "true"

marki1an · 2025-11-14T07:18:04Z

-                "adapter-defaults.ortb.multiformat-supported": "true")
+    private static final Map<String, String> ENABLED_MULTI_FORMAT = ["adapter-defaults.ortb.multiformat-supported": "true"]
+    private static final Map<String, String> DISABLED_MULTI_FORMAT = ["adapter-defaults.ortb.multiformat-supported": "false"]
+    private static final Map<String, String> DISABLED_MULTI_FORMAT_DEFAULT = [


Please format according to the usual format

marki1an · 2025-11-14T07:19:56Z

+            "adapters.generic.ortb.multiformat-supported": "false"
+    ]
+
+    private static def enabledMultiFormatPbsService = pbsServiceFactory.getService(ENABLED_MULTI_FORMAT)


Please change ''def'' to the right object

marki1an · 2025-11-14T07:22:03Z

+    PrebidServerService prebidServerService = pbsServiceFactory.getService(SCHAIN_NODE_CONFIG)
    @Shared
-    PrebidServerService prebidServerService = pbsServiceFactory.getService(["auction.host-schain-node": encode(GLOBAL_SUPPLY_SCHAIN_NODE)])
+    PrebidServerService prebidServerServiceWithElderOrtb = pbsServiceFactory.getService(ORTB_2_5_CONFIG)


Please add private static final

marki1an · 2025-11-14T07:24:53Z

+    private static final PrebidServerService storedRequestIdGenEnabledService = pbsServiceFactory.getService(STORED_REQUEST_ID_GEN_ENABLED_CONFIG)
+    private static final PrebidServerService storedRequestIdGenDisabledService = pbsServiceFactory.getService(STORED_REQUEST_ID_GEN_DISABLED_CONFIG)


Weird naming

marki1an

And please take a look at:
GppCookieSyncSpec.PBS shouldn't emit error message when request doesn't contain gdpr config and global skip gdpr config for adapter

osulzhenko · 2025-11-28T08:36:52Z

WIP

…nal-tests # Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/GppCookieSyncSpec.groovy

github-actions · 2025-12-03T21:30:00Z

	Tests	Passed ✅	Skipped ⚠️	Failed
JUnit Test Report	9058 ran	9056 passed	2 skipped	0 failed

View JUnit Test Report

…nal-tests # Conflicts: # src/test/groovy/org/prebid/server/functional/testcontainers/Dependencies.groovy

# Conflicts: # src/test/groovy/org/prebid/server/functional/testcontainers/Dependencies.groovy

osulzhenko added the tests Functional or other tests label Jan 6, 2025

osulzhenko requested a review from marki1an January 6, 2025 08:07

osulzhenko self-assigned this Jan 6, 2025

osulzhenko marked this pull request as draft January 8, 2025 12:28

osulzhenko force-pushed the refactoring-functional-tests branch from 6ad3b09 to 26f38ea Compare January 13, 2025 10:17

Refactoring functional tests

c6ddf01

osulzhenko force-pushed the refactoring-functional-tests branch from 26f38ea to c6ddf01 Compare January 14, 2025 09:36

Merge branch 'refs/heads/master' into refactoring-functional-tests

f10db31

# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/AmpFpdSpec.groovy

osulzhenko marked this pull request as ready for review January 14, 2025 09:38

Refactoring functional tests

ec3b6a2

osulzhenko added 5 commits February 4, 2025 14:29

Resolve conflicts

a31c436

update clean up for tests

ed705d0

Fix invalid tests

92b055c

Merge branch 'refs/heads/master' into refactoring-functional-tests

479ab21

# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/ActivityTraceLogSpec.groovy

marki1an requested changes Feb 17, 2025

View reviewed changes

osulzhenko added 3 commits February 21, 2025 14:30

Update after review

fa6de4d

Update after review

dca221a

Update after review

72bb241

osulzhenko requested a review from marki1an February 24, 2025 13:54

osulzhenko changed the title ~~Refactoring functional tests~~ Tests: Refactoring functional tests Feb 28, 2025

Merge branch 'refs/heads/master' into refactoring-functional-tests

e24537f

# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy

osulzhenko added the do not port label Mar 21, 2025

marki1an reviewed Mar 31, 2025

View reviewed changes

osulzhenko added 2 commits April 11, 2025 08:59

Merge branch 'refs/heads/master' into refactoring-functional-tests

229966e

update after review

0b11156

osulzhenko requested a review from marki1an April 11, 2025 06:00

osulzhenko added 2 commits April 25, 2025 10:59

Merge branch 'refs/heads/master' into refactoring-functional-tests

430d0ac

Merge branch 'refs/heads/master' into refactoring-functional-tests

9db9b6a

osulzhenko added 6 commits October 31, 2025 10:27

fix imports

f5e6593

fix imports

d3371fb

fix mr conflicts

11f47a3

Optimize module tests

8a4d564

fix gpp error

de08366

update module tests

6f32685

osulzhenko removed the blocked label Nov 7, 2025

Merge branch 'refs/heads/master' into refactoring-functional-tests

42acf18

marki1an requested changes Nov 14, 2025

View reviewed changes

marki1an mentioned this pull request Nov 19, 2025

Test: Fix for connection reset error in rule engine spec #4290

Closed

21 tasks

marki1an added 4 commits December 2, 2025 17:09

Move creation of local stack container

82c8a7d

Removing duplication and add NOOP metrics

5761e58

Merge remote-tracking branch 'origin/master' into refactoring-functio…

1b0aacc

…nal-tests # Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/GppCookieSyncSpec.groovy

Resolve conflict

ef7d348

marki1an added 2 commits December 4, 2025 13:04

Update: Remove unnecessary metics checks

a091b96

Update: Remove unnecessary metics checks

4fb9287

osulzhenko added blocked work in progress Signals not finished work and removed blocked labels Dec 12, 2025

marki1an self-requested a review December 22, 2025 10:23

Merge remote-tracking branch 'origin/master' into refactoring-functio…

ae8d1d3

…nal-tests # Conflicts: # src/test/groovy/org/prebid/server/functional/testcontainers/Dependencies.groovy

osulzhenko marked this pull request as draft January 2, 2026 09:10

osulzhenko added blocked and removed blocked labels Jan 2, 2026

osulzhenko added blocked and removed blocked labels Jan 16, 2026

Merge branch 'refs/heads/master' into refactoring-functional-tests

41509ae

# Conflicts: # src/test/groovy/org/prebid/server/functional/testcontainers/Dependencies.groovy

		private static PrebidServerService pbsServiceWithEnabledMediaFilter
		private static PrebidServerService pbsServiceWithEnabledMediaFilterAndDifferentCaseStrategy

		private static final PrebidServerService storedRequestIdGenEnabledService = pbsServiceFactory.getService(STORED_REQUEST_ID_GEN_ENABLED_CONFIG)
		private static final PrebidServerService storedRequestIdGenDisabledService = pbsServiceFactory.getService(STORED_REQUEST_ID_GEN_DISABLED_CONFIG)

Conversation

osulzhenko commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🔎 New Bid Adapter Checklist

🧪 Test plan

🏎 Quality check

Uh oh!

osulzhenko commented Jan 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marki1an Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marki1an Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

marki1an Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

marki1an Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

marki1an Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

marki1an Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

marki1an left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

osulzhenko commented Nov 28, 2025

Uh oh!

github-actions Bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

osulzhenko commented Jan 6, 2025 •

edited

Loading

marki1an left a comment •

edited

Loading

github-actions Bot commented Dec 3, 2025 •

edited

Loading