Skip to content

Fix DOM XSS in a11y-snapshot-scanner fixSuggestion rendering #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenscience merged 1 commit into from
Jul 30, 2026
Merged

Fix DOM XSS in a11y-snapshot-scanner fixSuggestion rendering #807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions data/themes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
"description": "Clean single-column layout. ATS-compliant, zero JavaScript, A4 print-ready. System fonts only.",
"author": "Praveen Kumar Purushothaman"
},
{
"id": "cosmic",
"name": "Cosmic",
"description": "Two-column layout, Immersive starry backdrop, Glowing elements, Monospace typography.",
"author": "Riya Halbhavi"
},
{
"id": "cyber",
"name": "Cyber",
Expand All @@ -24,12 +30,6 @@
"description": "Two-column layout, Black, grey, and white color scheme, Minimalist and clean.",
"author": "Riya Halbhavi"
},
{
"id": "cosmic",
"name": "Cosmic",
"description": "Two-column layout, Immersive starry backdrop, Glowing elements, Monospace typography.",
"author": "Riya Halbhavi"
},
{
"id": "resume-opus-5",
"name": "Opus 5",
Expand Down
6 changes: 5 additions & 1 deletion tools/a11y-snapshot-scanner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,8 +1179,12 @@ <h6>Hardware Interface Pins</h6>
descName = btn.value || btn.getAttribute("aria-label") || btn.getAttribute("title");
}

function escapeHtml(str) {
return String(str).replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;").replace(/'/g, "&#039;");
}

if (!descName || descName.trim() === "") {
addFinding("error", "Unlabeled Button Action", btn, "The button element has no textual description. Screen-readers will announce the element simply as 'button', blocking interaction guidance.", `<button aria-label="Action Description">${btn.innerHTML || "Submit"}</button>`);
addFinding("error", "Unlabeled Button Action", btn, "The button element has no textual description. Screen-readers will announce the element simply as 'button', blocking interaction guidance.", `<button aria-label="Action Description">${escapeHtml(btn.innerHTML) || "Submit"}</button>`);
}
});

Expand Down
Loading