Merged
Conversation
Remove the fullscreen height cap on visualize tool cards, keep the footer content-sized, and add Playwright coverage for both fullscreen regressions.
cpsievert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the visualize tool's fullscreen card layout so charts can use the full viewport height without the footer stretching to consume leftover space.
Simplify the fullscreen-specific CSS to the selectors and rules that are actually needed for the shinychat-based fullscreen path.
Add Playwright regressions covering tall/narrow fullscreen sizing and non-stretching fullscreen footers.
Verification
uv run ruff check --fix pkg-py --config pyproject.toml
make py-check-types
make py-check-tests
uv run pytest pkg-py/tests/playwright/test_10_viz_inline.py::TestInlineVisualization::test_fullscreen_uses_available_height_in_tall_viewport -q
uv run pytest pkg-py/tests/playwright/test_10_viz_inline.py::TestInlineVisualization::test_fullscreen_footer_does_not_stretch -q