test: add consumer type-check integration tests#5
Closed
Conversation
Simulates a real npm consumer by creating a temp project that imports @posit-dev/positron and runs tsc against it. Tests three configurations: commonjs with skipLibCheck false (the issue #4 case), commonjs with skipLibCheck true, and Node16 module resolution.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@posit-dev/positronand runningtscagainst itskipLibCheck: false, commonjs +skipLibCheck: true, andNode16module resolutiondist/and@types/vscodeinto it, writes a minimal.tsfile, and runstsc --noEmitNote: The
skipLibCheck: falseandNode16tests will fail onmainbecause issue #4 is not yet fixed there. They pass onfix/issue-4-bundle-vscode-dts. This PR can merge after #4 is resolved, or simultaneously.Test plan
skipLibCheck: falsetest correctly reproduces the issue TypeScript compilation errors: missing reference path files in published package #4 errors onmain(proving it catches the bug class)