Refactor bootstrap.bash to improve readability of the bootstrap steps#200
Merged
Merged
Conversation
Refactor bootstrap.bash: 1. Use "go run" to execute each step: this allows to build, run, and cleanup the binary in a single line 2. Make each step a single command with an explicit list of source files which are part of the build, and aligned input and output files: this improves readibility 3. Cleanup intermediate files in case of success. 4. As the previous build script was leaving artefacts, add cleanup of those obsolete artefacts as they are no longer relevant and could be misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
bootstrap.bash:Extract of the final script:
Note: next refactor step should about refactoring ./bootstrap/main.go to make its output more explicit.