Add Go package aliased import (#182)#197
Merged
Merged
Conversation
dolmen
force-pushed
the
add-import-with-alias
branch
from
668d698 to
d269519
Compare
Add aliased import of Go packages, like in full Go:
import myfmt "fmt"
The implementation is a hack:
- during parsing an import alias is stored as a fake import with an '=' prefix
- during compile, the alias is merged with the following import as <import-path>=<alias>
- during Go code generation (tree/peg.go.tmpl), the string is split
So import aliases are not properly represented in tree.Tree.
Closes pointlander#182.
dolmen
force-pushed
the
add-import-with-alias
branch
from
d269519 to
371b841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add aliased import of Go packages in
PEGfiles, like in full Go:The implementation is a hack:
<import-path>=<alias>tree/peg.go.tmpl), the string is split using a function imported in the templateSo import aliases are not properly represented as specific nodes in the AST
tree.Tree, but that representation fits the purpose.Closes #182.