test(vita): regenerate animation goldens after the raster changes (#173, #190) - #206
Merged
Merged
Conversation
…, #190) The damage-rendering (#173) and transactional-strip (#190) merges moved rasterization; the Vita3K animation goldens (gallery/motions/music) predate both and there is no CI that reruns the Vita e2e, so the drift sat silent until the next full local run: 7 frames failing byte-compare. Attribution was verified before regenerating: a pristine origin/main worktree reproduces every failing frame byte-identically to the feature branch that surfaced them (cmp on the actuals), so the drift belongs to main, not to any open stack. The deltas are 131-456 pixels of 522,240 (<0.1%) per frame - one-logical-pixel edge shifts on animated elements - and were reviewed visually before UPDATE_VITA=1 recapture. Verify pass after regen: gallery 6/6, motions 5/5, music 4/4. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The damage-rendering (#173) and transactional-strip (#190) merges moved rasterization; the Vita3K animation goldens (
gallery/motions/music) predate both, and no CI reruns the Vita e2e — so the drift sat silent until the next full local run: 7 frames failing byte-compare (gallery-main 42/82/132/178/226, motions-main 236, music-main 60).Attribution
Verified before regenerating: a pristine
origin/mainworktree reproduces every failing frame byte-identically (cmpon the actuals) to the feature branch that surfaced them — the drift belongs to main, not to any open stack.The drift
131–456 pixels of 522,240 (<0.1%) per frame: one-logical-pixel edge shifts on animated elements (e.g. the gallery focus ring 2 physical px left at f42). Reviewed visually before recapture — indistinguishable by eye.
Regen + verify
UPDATE_VITA=1recapture per spec, then a clean verify pass: gallery 6/6, motions 5/5, music 4/4.🤖 Generated with Claude Code