RFC: locked build environments for git-hosted dependencies - #21
Draft
zkochan wants to merge 1 commit into
Draft
Conversation
Propose recording the package manager and runtime that prepare a git-hosted dependency (exact versions plus integrity) in the consuming project's lockfile, making the record authoritative on later installs, and provisioning the Node.js runtime pinned by devEngines.runtime. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When pnpm builds a git-hosted dependency, the package manager that runs the build (Yarn, npm, Bun, or pnpm) is resolved live from the registry — often from a floating spec sniffed from the dependency's lockfile — and the build always runs on the host's Node.js. This RFC proposes to:
devEngines.runtime, symmetric with how the package manager is already provisioned fromdevEngines.packageManager/packageManager.Motivation in two sentences: floating package-manager specs make git-dependency builds nondeterministic across machines and time (undetectably, since git resolutions carry no integrity), and
--frozen-lockfilecurrently downloads and executes an unlocked executable resolved live from the registry — a hole in both reproducibility and the supply-chain guarantee the lockfile is supposed to provide.Opened as a draft for discussion; the Unresolved Questions section lists the open naming/shape/scope decisions.
Written by an agent (Claude Code, claude-fable-5).