fix: avoid accumulating overlay entries across rebuilds - #1055
Open
OskarEichler wants to merge 1 commit into
Open
fix: avoid accumulating overlay entries across rebuilds#1055OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Stop accumulating duplicate error-overlay entries across rebuilds when using socket integrations such as webpack-hot-middleware.
socketEntryDatacurrently lives for the entire compiler lifetime and is appended to on everymake. Three real sequential compilations produce one, two, and three overlay dependencies respectively. Stale entry names are also retained when a dynamic entry function changes its output.Implementation
Discover integration positions inside the existing
finishMakecallback, using only the current compilation. This removes the separatemakehook and persistent mutable array. Overlay placement remains immediately after the integration entry, and the global-entry fallback is preserved.Verification
Compatibility / breaking changes
No public API, dependency, runtime, or supported-platform changes. This fixes compilation bookkeeping and removes work that increased with each rebuild; no application rendering-performance claim.