Skip to content

Clarify tsconfig.playwright.json types and harden typecheck:app #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plx merged 1 commit into from
Apr 28, 2026
Merged

Clarify tsconfig.playwright.json types and harden typecheck:app #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"dev:network": "astro dev --host",
"build": "astro check && astro build",
"typecheck": "npm run typecheck:app && npm run typecheck:playwright",
"typecheck:app": "tsc -p tsconfig.json --noEmit",
"typecheck:app": "astro sync && tsc -p tsconfig.json --noEmit",
"typecheck:playwright": "tsc -p tsconfig.playwright.json --noEmit",
"preview": "astro preview",
"preview:network": "astro preview --host",
Expand Down
2 changes: 2 additions & 0 deletions tsconfig.playwright.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
// `types` replaces (not merges) the parent array; `astro/client` is
// intentionally dropped because Playwright tests don't need it.
"types": [
"node",
"@playwright/test"
Expand Down
Loading