Skip to content

Change logging from warning to debug to reduce logging#459

Merged
dirixmjm merged 7 commits into
mainfrom
ReduceLog
Jul 1, 2026
Merged

Change logging from warning to debug to reduce logging#459
dirixmjm merged 7 commits into
mainfrom
ReduceLog

Conversation

@dirixmjm

@dirixmjm dirixmjm commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Some of the battery nodes warning are really debug-related messages.

Summary by CodeRabbit

  • Chores
    • Reduced logging verbosity by downgrading several routine operational messages from warning to debug across node scanning, sense/switch group handling, SED maintenance/awake timer scenarios, and cache-disabled behavior.
  • Documentation
    • Added a new changelog entry for version 0.47.8 noting reduced SED logging verbosity.
  • Chores
    • Bumped pre-commit hook versions and updated the package version to 0.47.8.

@dirixmjm dirixmjm requested a review from a team as a code owner June 20, 2026 13:09
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 32e2d191-f7b7-4218-94ae-5087eb54b2f1

📥 Commits

Reviewing files that changed from the base of the PR and between 8408420 and 91dbcf6.

📒 Files selected for processing (3)
  • .pre-commit-config.yaml
  • CHANGELOG.md
  • pyproject.toml
✅ Files skipped from review due to trivial changes (2)
  • CHANGELOG.md
  • pyproject.toml

📝 Walkthrough

Walkthrough

The PR lowers several routine node-module log messages from warning to debug and updates release metadata for version 0.47.8, including the changelog, package version, and two pre-commit hook revisions.

Changes

Log Level Reduction

Layer / File(s) Summary
warning → debug log downgrades
plugwise_usb/nodes/node.py, plugwise_usb/nodes/scan.py, plugwise_usb/nodes/sed.py, plugwise_usb/nodes/sense.py
_LOGGER.warning(...) is changed to _LOGGER.debug(...) for the caching-disabled path, switch-group responses, motion reset timer adjustment, maintenance interval detection, and awake-timer unavailability messages.

Release Metadata Update

Layer / File(s) Summary
version, changelog, and hook bumps
pyproject.toml, CHANGELOG.md, .pre-commit-config.yaml
The project version is bumped to 0.47.8, the changelog adds the 0.47.8 - 2026-07-01 entry referencing PR #459, and the Ruff and Biome pre-commit hook revisions are updated.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bouwew

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: lowering log severity from warning to debug to reduce noise.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ReduceLog

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot requested a review from bouwew June 20, 2026 13:09
@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.78%. Comparing base (58de8c6) to head (91dbcf6).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
plugwise_usb/nodes/sed.py 0.00% 2 Missing ⚠️
plugwise_usb/nodes/sense.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          36       36           
  Lines        8192     8192           
=======================================
  Hits         6700     6700           
  Misses       1492     1492           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

renovate Bot added 2 commits June 25, 2026 00:56
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

@bouwew bouwew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderabbitai coderabbitai Bot requested a review from bouwew July 1, 2026 08:26
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@dirixmjm dirixmjm merged commit 16e3dc7 into main Jul 1, 2026
16 of 17 checks passed
@dirixmjm dirixmjm deleted the ReduceLog branch July 1, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants