Skip to content

feat: make plugin CSP compliant - #148

Draft
Rom1-B wants to merge 1 commit into
11.0/bugfixesfrom
csp-compliance
Draft

Rom1-B wants to merge 1 commit into
11.0/bugfixesfrom
csp-compliance

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • Makes the plugin compatible with the Content Security Policy sent by GLPI (script-src with a per-request nonce, no inline handlers).
  • Inline script blocks printed from PHP now go through Html::scriptBlock() and Html::script(), so they receive the nonce.
  • The inline onclick of the tree close button is replaced by a listener bound from a script block.
  • The dTree library (public/lib/dtree/dtree.js, not modified) still renders onclick and javascript: links; a script block placed after the tree rebinds them to listeners that call the same d.o(id) / d.s(id) functions, and restores the status bar text on hover.
  • Declares 'csp_compliant' => true in plugin_version_treeview().

Converted patterns

  • public/left.php: onclick attribute on the explorer close span, replaced by an id and a listener.
  • inc/config.class.php:
    • seeTreeview() and hideTreeview(): frame-breaking inline scripts, now Html::scriptBlock().
    • buildTreeview(): dTree <script src> now Html::script(); the tree initialisation script now Html::scriptBlock(); new rebinding script after the tree.
  • hook.php: three parent.left.location.reload(true) inline scripts, now Html::scriptBlock().
  • front/config.form.php: frame-breaking inline script, now Html::scriptBlock().
  • setup.php: csp_compliant key.
  • CHANGELOG.md: Unreleased entry.

Blocked by

  • Add content security policy glpi-project/glpi#26020 (CSP) and its 11.0 / 12.0 backports, still open.
  • The minimum GLPI version (PLUGIN_TREEVIEW_MIN_GLPI, currently 11.0.0) must be bumped to the first CSP-enabled release before merging. Before that release, the nonce is not added and the scripts are blocked by the browser.

Manual test checklist

Keep the browser console open: CSP violations show up as Refused to execute inline ....

  1. Open the tree view (plugins/treeview/index.php). Expand and collapse folders with the +/- toggles: folders open and close, no console error.
  2. Click an item node: it is highlighted and its form opens in the right frame.
  3. With the status text option enabled (Setup, Tree view), hover a node: the browser status bar shows its name; leaving the node clears it.
  4. Click the close (x) button in the tree header: the right frame reloads to its current page.
  5. Change the location of an item or location: the tree frame reloads.
  6. Delete or restore an item shown in the tree: the tree frame reloads.
  7. Change the active entity while the tree is loaded: the tree frame reloads.
  8. Open Setup, Tree view outside the frameset: no script error.
  9. Log out while the tree is loaded: no script error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant