Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Html::scriptBlock()andHtml::script(), so they receive the nonce.onclickof the tree close button is replaced by a listener bound from a script block.public/lib/dtree/dtree.js, not modified) still rendersonclickandjavascript:links; a script block placed after the tree rebinds them to listeners that call the samed.o(id)/d.s(id)functions, and restores the status bar text on hover.'csp_compliant' => trueinplugin_version_treeview().Converted patterns
public/left.php:onclickattribute on the explorer close span, replaced by an id and a listener.inc/config.class.php:seeTreeview()andhideTreeview(): frame-breaking inline scripts, nowHtml::scriptBlock().buildTreeview(): dTree<script src>nowHtml::script(); the tree initialisation script nowHtml::scriptBlock(); new rebinding script after the tree.hook.php: threeparent.left.location.reload(true)inline scripts, nowHtml::scriptBlock().front/config.form.php: frame-breaking inline script, nowHtml::scriptBlock().setup.php:csp_compliantkey.CHANGELOG.md: Unreleased entry.Blocked by
PLUGIN_TREEVIEW_MIN_GLPI, currently 11.0.0) must be bumped to the first CSP-enabled release before merging. Before that release, the nonce is not added and the scripts are blocked by the browser.Manual test checklist
Keep the browser console open: CSP violations show up as
Refused to execute inline ....plugins/treeview/index.php). Expand and collapse folders with the +/- toggles: folders open and close, no console error.