Fix: Fatal error on redirection after ticket transfer (GLPI 11) - #32
Open
Windayz wants to merge 2 commits into
Open
Fix: Fatal error on redirection after ticket transfer (GLPI 11)#32Windayz wants to merge 2 commits into
Windayz wants to merge 2 commits into
Conversation
Collaborator
|
Please resolve conflict |
Author
|
It's good |
Collaborator
|
Please lauch cs fixer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
In GLPI 11, when a user transfers a ticket to an entity where they do not have
READaccess, the plugin attempts to redirect back to the ticket form (Html::redirect). The new Symfony kernel strictly intercepts this missing right and throws anAccessDeniedHttpException/ Fatal Error.To Reproduce
Expected behavior
As in GLPI 10, the user should be redirected to the tickets list (
Ticket::getSearchURL()) with an information message.Solution
Added a check using
$ticket->can($ticket->getID(), READ)right before the final redirection inlaunchTicketTransfer().