Fix tag item association - #372
Open
Herafia wants to merge 4 commits into
Open
Conversation
Herafia
force-pushed
the
fix/tag-associate-item
branch
from
August 21, 2026 10:36
4024518 to
e9c3d61
Compare
Herafia
force-pushed
the
fix/tag-associate-item
branch
from
August 21, 2026 13:12
e9c3d61 to
569201f
Compare
Herafia
force-pushed
the
fix/tag-associate-item
branch
from
August 21, 2026 13:42
2b655a6 to
0a31762
Compare
stonebuzz
requested changes
Aug 21, 2026
| echo "<div class='firstbloc'>"; | ||
| echo "<form name='tagitem_form{$rand}' id='tagitem_form{$rand}' method='post' | ||
| action='" . Toolbox::getItemTypeFormURL('PluginTagTag') . "'>"; | ||
| action='" . plugin_tag_geturl() . "/ajax/add_item_to_tag.php'>"; |
Contributor
There was a problem hiding this comment.
This association should not be handled through an AJAX file.
Instead, a dedicated controller should be created for TagItem. It should handle the add action, which should be renamed to associate to better reflect its purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Regression : The file front/tag.form.php, which handled this association, had been accidentally deleted in an unrelated commit. The request was then processed by the generic mechanism, which created a tag instead of establishing the association.
Fix : re-enable correct processing of the tag/item association.
Screenshots (if appropriate):