Feat: rename oversized containers from their edit form - #1248
Open
Rom1-B wants to merge 4 commits into
Open
Conversation
stonebuzz
requested changes
Aug 24, 2026
|
|
||
| return false; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
renameOversizedContainer has no server-side guard that the target container is actually disabled or oversized.
Suggested change
| if ((int) $container->fields['is_active'] !== 0) { | |
| Session::AddMessageAfterRedirect(__('Container is already active.', 'fields'), false, ERROR); | |
| return false; | |
| } |
Contributor
Author
There was a problem hiding this comment.
Good catch, but a strict is_active === 0 check would break the orphan-recovery path (an active container whose table got corrupted by an old migration bug, see testRenameOversizedContainerRecoversDataFromOrphanTable). Added a guard instead that requires the container's current name to actually produce an oversized table, same condition already used to show the "Rename and reactivate" button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
plugins:fields:check_databasenow also reports container/item type pairs with no matching table, and tables with no matching container/item type pair.Screenshots (if appropriate):