Skip to content

Fixed: the Getting Started Guide's Next button would stay disabled after entering (or pasting) a Plugin Token. #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dan0sz merged 3 commits into from
Aug 10, 2026
+280 −208
Merged

Fixed: the Getting Started Guide's Next button would stay disabled after entering (or pasting) a Plugin Token. #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b25b9b
Update translations.
Dan0sz Aug 10, 2026
41228fe
Removed Changelog.md
Dan0sz Aug 10, 2026
3be3c33
* Fixed: the Getting Started Guide's Next button would stay disabled …
Dan0sz Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions CHANGELOG.md
View file
Open in desktop

This file was deleted.

49 changes: 28 additions & 21 deletions assets/src/js/admin/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ document.addEventListener('DOMContentLoaded', () => {
createAPITokenElems: document.getElementsByClassName('plausible-create-api-token'),
buttonElems: document.getElementsByClassName('plausible-analytics-button'),
stepElems: document.getElementsByClassName('plausible-analytics-wizard-next-step'),
credentialsInputs: document.querySelectorAll('.plausible-analytics-credentials input'),
/**
* Credentials (Domain Name/Plugin Token) are entered in the settings screen, as well as in the wizard's slides.
*/
credentialsInputs: document.querySelectorAll('.plausible-analytics-credentials input, .plausible-analytics-wizard-step-section input'),
languageDomainPulldown: document.getElementById('language_domain'),
connectButtons: document.querySelectorAll('.plausible-analytics-credentials .plausible-analytics-connect-button'),

Expand Down Expand Up @@ -68,7 +71,11 @@ document.addEventListener('DOMContentLoaded', () => {

if (this.credentialsInputs.length > 0) {
for (let i = 0; i < this.credentialsInputs.length; i++) {
this.credentialsInputs[i].addEventListener('keyup', this.disableConnectButton);
/**
* We're listening for input (instead of keyup) events, because the value can be changed without
* using the keyboard, e.g. by pasting it using the mouse, or a password manager.
*/
this.credentialsInputs[i].addEventListener('input', this.disableConnectButton);
}
}

Expand Down Expand Up @@ -487,15 +494,14 @@ document.addEventListener('DOMContentLoaded', () => {
},

/**
* Disable the Connect button if the Domain Name or API Token field is empty.
* Disable the Connect/Next button if the Domain Name or API Token field is empty.
*
* @param e
*/
disableConnectButton: function (e) {
let target = e.target;
let credentials = target.closest('.plausible-analytics-credentials');
let button;
let buttonIsHref = false;

if (credentials !== null) {
button = credentials.querySelector('.plausible-analytics-connect-button');
Expand All @@ -516,32 +522,33 @@ document.addEventListener('DOMContentLoaded', () => {
return;
}

let slide_id = document.location.hash;
button = document.querySelector(slide_id + ' .plausible-analytics-wizard-next-step');
buttonIsHref = true;
/**
* The wizard's Next button is an anchor, which can't be disabled, so we're toggling its pointer-events and
* background color instead.
*/
let step = target.closest('.plausible-analytics-wizard-step-section');

if (button === null) {
if (step === null) {
return;
}

if (target.value !== '') {
if (!buttonIsHref) {
button.disabled = false;
} else {
button.classList.remove('pointer-events-none');
button.classList.replace('bg-gray-200', 'bg-indigo-600');
}
button = step.querySelector('.plausible-analytics-wizard-next-step');

if (button === null) {
return;
}

if (!buttonIsHref) {
button.disabled = true;
button.textContent = button.textContent.replace('Connected', 'Connect');
} else {
button.classList += ' pointer-events-none';
button.classList.replace('bg-indigo-600', 'bg-gray-200');
let allFilled = Array.from(step.querySelectorAll('input')).every(input => input.value.trim() !== '');

if (allFilled) {
button.classList.remove('pointer-events-none');
button.classList.replace('bg-gray-200', 'bg-indigo-600');

return;
}

button.classList.add('pointer-events-none');
button.classList.replace('bg-indigo-600', 'bg-gray-200');
},

/**
Expand Down
Loading
Loading