Better error message change domain#6462
Open
aerosol wants to merge 3 commits into
Open
Conversation
aerosol
commented
Jun 25, 2026
| BEGIN | ||
| IF EXISTS ( | ||
| SELECT 1 FROM sites | ||
| WHERE (NEW.domain = domain_changed_from AND NEW.id != id AND (team_id IS NULL OR NEW.team_id IS NULL OR team_id != NEW.team_id)) |
Member
Author
There was a problem hiding this comment.
Technically we take a good care to prevent site.team_id from ever being NULL (wondering if we can now use regular DB constraint to guarantee that), but the additional check here shouldn't hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two UX improvements for domain change:
Migration will be extracted once review is concluded.