Fix wildcard pathname regex used for funnel steps and prev step exclusion#6343
Merged
Conversation
|
zoldar
force-pushed
the
funnel-next-steps-visitor-discrepancy
branch
from
b043a5a to
e8f6697
Compare
zoldar
changed the title
uniqExact in place of uniq
aerosol
approved these changes
May 12, 2026
aerosol
pushed a commit
that referenced
this pull request
May 12, 2026
…sion (#6343) * Relax wildcard pattern used in funnel step condition * Add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The pathname regular expression turned out to be out of sync with how we defined wildcard pathname events in suggestions. It didn't matter when we were normalizing pathnames. However, since we have dropped the normalization for consistency, this inconsistency has crept it.
Tests