fix: generate correct TS type for array-form type (OpenAPI 3.1 nullable)#171
Open
Akallabet wants to merge 1 commit into
Open
fix: generate correct TS type for array-form type (OpenAPI 3.1 nullable)#171Akallabet wants to merge 1 commit into
type (OpenAPI 3.1 nullable)#171Akallabet wants to merge 1 commit into
Conversation
…able) When an OpenAPI 3.1 / JSON Schema 2020-12 schema expresses a type as an array (e.g. `type: ['string', 'null']`) instead of the 3.0 `nullable: true` keyword, `getType()` fell through to the `switch` default and emitted `unknown`. It only handled `type` being a single string. Resolve each member of the array-form `type` independently through `getType()` and join the results as a union, so `['string', 'null']` becomes `string | null`, `['object', 'null']` and `['array', 'null']` are handled correctly too. Fixes platformatic#170 Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Akallabet <grazianos86@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170.
Added a control that detects
Array.isArray(typeDef.type)and resolves each member type independently throughgetType(), joining the results as a union. This handles the common['string', 'null']case as well as['object', 'null']and['array', 'null'], since each member is routed through the existing per-type logic.Before:
'description'?: unknownAfter:
'description'?: string | null