✨ Add optional dependency fabric-permissions-api to fabric publish - #4796
Merged
Conversation
AuroraLS3
approved these changes
Aug 11, 2026
Collaborator
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.
/Plan/common/src/main/java/com/djrapitops/plan/delivery/rendering/html/Contributors.javaDescription
This adds the fabric-permissions-api to the modrinth publish because using that for permission is recommended over Fabric itself. Not possible for Curseforge because apperently it's not published there.
This also unifies the dependency from fabric.mod.json with the publishing dependencies. To simplify the workflow mc-publish now publishes the fabric build to modrinth and curseforge at the same time. This also saves some performance / build time.