chore: release#174
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (5)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughVersion bumps across four workspace crates: ChangesRelease Version Bumps
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
crates/soar-package/CHANGELOG.md (1)
2-6: ⚡ Quick winDocument breaking API changes in the changelog.
The soar-package v0.4.0 changelog mentions a bug fix but does not document the breaking changes stated in the PR objectives: the parameter count changes in
symlink_desktop(2→3 parameters) andsymlink_desktop_with_config(3→4 parameters). While the minor version bump signals a breaking change, explicit "[BREAKING]" or similar notation in the changelog would improve visibility for users upgrading from 0.3.3.📝 Suggested changelog update
## [0.4.0](https://github.com/pkgforge/soar/compare/soar-package-v0.3.3...soar-package-v0.4.0) - 2026-06-14 ### 🐛 Bug Fixes - *(integrate)* Don't clobber desktop Icon field when package ships no matching icon - ([caf1ba6](https://github.com/pkgforge/soar/commit/caf1ba6dd7df4cb227161dfa2530acc985e04dd3)) + +### ⚠️ Breaking Changes + +- *(formats::common)* `symlink_desktop` now requires 3 parameters (added config parameter) +- *(formats::common)* `symlink_desktop_with_config` now requires 4 parameters🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/soar-package/CHANGELOG.md` around lines 2 - 6, The soar-package v0.4.0 changelog section does not explicitly document the breaking API changes that were introduced in this version. Add a new "[BREAKING]" section to the v0.4.0 changelog entry to document the parameter count changes in the symlink_desktop function (from 2 to 3 parameters) and the symlink_desktop_with_config function (from 3 to 4 parameters). This will improve visibility for users upgrading from 0.3.3 and ensure the changelog clearly communicates the breaking changes alongside the bug fix that is already documented.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 2-7: Replace the placeholder commit hash 0000000 with the actual
release commit hash 5a1db54 in the changelog entry to fix the broken link.
Additionally, update the package list in the changelog to match the configured
packages in .release-plz.toml: replace the currently listed "soar-package,
soar-core, soar-operations" with the correct package references from the
configuration file which specifies "soar-config" and "soar-core".
- Around line 4-6: The CHANGELOG.md entry lists "soar-package, soar-core,
soar-operations" but the .release-plz.toml file specifies changelog_include as
"soar-config, soar-core" for the soar-cli release. Synchronize these by either
updating the CHANGELOG.md entry to match the .release-plz.toml configuration
(changing the package list to "soar-config, soar-core"), or alternatively,
update the changelog_include list in .release-plz.toml to include all direct
dependencies of soar-cli that are actually being tracked. Choose one approach
and ensure both files are consistent.
---
Nitpick comments:
In `@crates/soar-package/CHANGELOG.md`:
- Around line 2-6: The soar-package v0.4.0 changelog section does not explicitly
document the breaking API changes that were introduced in this version. Add a
new "[BREAKING]" section to the v0.4.0 changelog entry to document the parameter
count changes in the symlink_desktop function (from 2 to 3 parameters) and the
symlink_desktop_with_config function (from 3 to 4 parameters). This will improve
visibility for users upgrading from 0.3.3 and ensure the changelog clearly
communicates the breaking changes alongside the bug fix that is already
documented.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f1f16cb4-616c-4cfb-9558-a26f7c45174e
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (9)
CHANGELOG.mdCargo.tomlcrates/soar-cli/Cargo.tomlcrates/soar-core/CHANGELOG.mdcrates/soar-core/Cargo.tomlcrates/soar-operations/CHANGELOG.mdcrates/soar-operations/Cargo.tomlcrates/soar-package/CHANGELOG.mdcrates/soar-package/Cargo.toml
| ## [0.12.4](https://github.com/pkgforge/soar/compare/v0.12.3...v0.12.4) - 2026-06-14 | ||
|
|
||
| ### ⚙️ Miscellaneous Tasks | ||
|
|
||
| - Updated the following local packages: soar-package, soar-core, soar-operations - ([0000000](https://github.com/pkgforge/soar/commit/0000000)) | ||
|
|
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check for the actual commit that corresponds to v0.12.4
git log --oneline --all | grep -i "0.12.4\|bump.*version" | head -20Repository: pkgforge/soar
Length of output: 39
🏁 Script executed:
# Check current git state and recent commits
git log --oneline -10Repository: pkgforge/soar
Length of output: 80
🏁 Script executed:
# Look for .release-plz.toml configuration
find . -name ".release-plz.toml" -o -name "release-plz.toml" | head -5Repository: pkgforge/soar
Length of output: 77
🏁 Script executed:
# Verify the CHANGELOG.md content at the mentioned lines
head -20 CHANGELOG.md | cat -nRepository: pkgforge/soar
Length of output: 1178
🏁 Script executed:
# Check the release commit details
git show 5a1db54 --stat | head -30Repository: pkgforge/soar
Length of output: 1704
🏁 Script executed:
# Get the full content of .release-plz.toml
cat ./.release-plz.tomlRepository: pkgforge/soar
Length of output: 2544
🏁 Script executed:
# Check git tags to confirm v0.12.4
git tag -l "*0.12.4*" -n1Repository: pkgforge/soar
Length of output: 39
Replace placeholder commit hash with actual commit reference.
Line 6 contains 0000000, a placeholder hash that creates a broken link. Replace it with 5a1db54 (the release commit hash) to ensure the changelog entry links correctly.
Additionally, verify that the package list "soar-package, soar-core, soar-operations" matches the configured packages in .release-plz.toml which specifies changelog_include=["soar-config", "soar-core"]. There is a mismatch: the changelog lists "soar-package" and "soar-operations" but the configuration includes "soar-config".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` around lines 2 - 7, Replace the placeholder commit hash 0000000
with the actual release commit hash 5a1db54 in the changelog entry to fix the
broken link. Additionally, update the package list in the changelog to match the
configured packages in .release-plz.toml: replace the currently listed
"soar-package, soar-core, soar-operations" with the correct package references
from the configuration file which specifies "soar-config" and "soar-core".
| ### ⚙️ Miscellaneous Tasks | ||
|
|
||
| - Updated the following local packages: soar-package, soar-core, soar-operations - ([0000000](https://github.com/pkgforge/soar/commit/0000000)) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, locate the .release-plz.toml file
find . -name ".release-plz.toml" -o -name "release-plz.toml" 2>/dev/nullRepository: pkgforge/soar
Length of output: 77
🏁 Script executed:
# Also look for CHANGELOG.md to understand the context better
find . -name "CHANGELOG.md" | head -20Repository: pkgforge/soar
Length of output: 374
🏁 Script executed:
# Check for Cargo.toml files in the repository
find . -name "Cargo.toml" | head -20Repository: pkgforge/soar
Length of output: 383
🏁 Script executed:
# Read the .release-plz.toml file
cat .release-plz.tomlRepository: pkgforge/soar
Length of output: 2544
🏁 Script executed:
# Read the main CHANGELOG.md to see the entry at lines 4-6
head -20 CHANGELOG.mdRepository: pkgforge/soar
Length of output: 1038
🏁 Script executed:
# Read soar-cli's Cargo.toml to see actual dependencies
cat crates/soar-cli/Cargo.tomlRepository: pkgforge/soar
Length of output: 1263
Changelog entry does not match release configuration.
The changelog lists "soar-package, soar-core, soar-operations" as updated packages, but .release-plz.toml specifies changelog_include: ["soar-config", "soar-core"] for the soar-cli release. The CHANGELOG.md entry should either:
- Update to match the configuration: "soar-config, soar-core" (as defined in
.release-plz.toml), or - Update
.release-plz.tomlto include all three packages being tracked: "soar-config", "soar-core", "soar-operations", "soar-package" (all direct dependencies of soar-cli per Cargo.toml)
Ensure the changelog_include configuration and the actual changelog entry are synchronized.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` around lines 4 - 6, The CHANGELOG.md entry lists "soar-package,
soar-core, soar-operations" but the .release-plz.toml file specifies
changelog_include as "soar-config, soar-core" for the soar-cli release.
Synchronize these by either updating the CHANGELOG.md entry to match the
.release-plz.toml configuration (changing the package list to "soar-config,
soar-core"), or alternatively, update the changelog_include list in
.release-plz.toml to include all direct dependencies of soar-cli that are
actually being tracked. Choose one approach and ensure both files are
consistent.
5a1db54 to
a1e0c5c
Compare
🤖 New release
soar-package: 0.3.3 -> 0.4.0 (⚠ API breaking changes)soar-core: 0.16.1 -> 0.16.2 (✓ API compatible changes)soar-operations: 0.2.2 -> 0.2.3 (✓ API compatible changes)soar-cli: 0.12.3 -> 0.12.4⚠
soar-packagebreaking changesChangelog
soar-packagesoar-coresoar-operationssoar-cliThis PR was generated with release-plz.
Summary by CodeRabbit
New Features
Bug Fixes