refactor: replace WaitNext with retry.Do in piped components#6996
Open
Nsanjayboruds wants to merge 2 commits into
Open
refactor: replace WaitNext with retry.Do in piped components#6996Nsanjayboruds wants to merge 2 commits into
Nsanjayboruds wants to merge 2 commits into
Conversation
Signed-off-by: Nsanjayboruds <nishantborude555@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Refactors the
pipedcomponent to replace all direct usages of the unsafebackoff.WaitNextmethod with the safer, closure-basedretry.Dopattern.Additionally, the
WaitNextfunction inpkg/backoff/backoff.gohas been unexported (renamed towaitNext) and removed from theRetryinterface to prevent future unsafe usage in the codebase.Why we need it:
The imperative
WaitNextretry loop approach was identified as unsafe because it could potentially lead to panics or skipped retries if a panic or unexpected error occurred inside the loop block. Migrating to the functionalretry.Doclosure ensures that execution logic and error handling (such aspipedservice.Retriable(err)) are properly encapsulated and safely managed by the retry mechanism.Which issue(s) this PR fixes:
Fixes #6995
Does this PR introduce a user-facing change?:
No