Use password-stdin in Kubernetes Helm provider#6994
Open
rootp1 wants to merge 2 commits into
Open
Conversation
Signed-off-by: rootp1 <arnav.iitr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked Issue
Fixes #6993
What Changed
Verification
Scope
What this PR does:
Stops the single-cluster Kubernetes Helm provider from exposing Helm passwords in process arguments by switching to stdin-based credential passing.
Why we need it:
It removes avoidable credential exposure in argv and aligns this provider with the safer multicluster implementation that already exists in the repository.
Which issue(s) this PR fixes:
Fixes #6993
Does this PR introduce a user-facing change?: