fix: avoid panic on missing application spec during migration#6983
Open
CodeWith-sakib wants to merge 3 commits into
Open
fix: avoid panic on missing application spec during migration#6983CodeWith-sakib wants to merge 3 commits into
CodeWith-sakib wants to merge 3 commits into
Conversation
Signed-off-by: Mohammad Sakib <mohammadsakib00978@gmail.com>
rahulshendre
reviewed
Jul 7, 2026
rahulshendre
left a comment
rahulshendre
left a comment
Contributor
There was a problem hiding this comment.
nice catch @CodeWith-sakib 🙌
@mohammedfirdouss @khanhtc1202 PTAL, when you have time
Contributor
LGTM @rahulshendre |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
pipectl migrate application-configfrom panicking when the input application configuration is missing or has an invalidspecfield.Why we need it:
Currently, the migration command performs an unchecked type assertion on the
specfield. When the field is missing or malformed, the command terminates with a Go panic instead of reporting a validation error. This change makes the migration command more robust and improves the user experience when handling invalid input.Which issue(s) this PR fixes:
Fixes #6980
Does this PR introduce a user-facing change?:
Yes
How are users affected by this change:
Users now receive a descriptive error message instead of a panic when running
pipectl migrate application-configwith an invalid application configuration that is missing or has an invalidspecfield.Is this breaking change:
No.
How to migrate (if breaking change):
N/A