docs: add Netlify configuration for docs hosting migration #6930
docs: add Netlify configuration for docs hosting migration #6930harshitghagre wants to merge 5 commits into
Conversation
Ayushmore1214
left a comment
There was a problem hiding this comment.
@harshitghagre can we get some screenshots of this working ? I'm having some issue with it, I don't if its my env or the your code can you drop some outputs of this running, thanks!
thanks for review @Ayushmore1214 , you can test on this url https://pipecd-docs.netlify.app/ |
khanhtc1202
left a comment
There was a problem hiding this comment.
Checked the testing link, it looks great. I left one comment on script update.
Also, why was the site on netlify doesn't contain the docs for v0.56.x?
It was misssing because the netlify build got timeout due to large page size, now i've increased build timeout. You can check on this url https://pipecd-docs.netlify.app/docs-v0.57.x/ |
rahulshendre
left a comment
There was a problem hiding this comment.
LGTM, @harshitghagre.
The DCO check is currently failing, please sign off your commit so the check passes
1cee855 to
b139d8f
Compare
ecfc37b to
326b28d
Compare
|
@rahulshendre please review |
|
Thanks for the nudge @mohammedfirdouss : ) |
Signed-off-by: harshitghagre <harshitghagre183@gmail.com>
4f5a7d1 to
81acc05
Compare
|
next time, @harshitghagre update the branch to match the base. @rahulshendre pinging for your review. |
got it, thanks! |
rahulshendre
left a comment
There was a problem hiding this comment.
LGTM, thanks @harshitghagre
@khanhtc1202, what about the account/ DNS 👀
|
@harshitghagre, please resolve the conflicts |
Signed-off-by: Harshit Ghagre <117425012+harshitghagre@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6930 +/- ##
===========================================
+ Coverage 29.35% 48.13% +18.78%
===========================================
Files 601 90 -511
Lines 64328 8671 -55657
===========================================
- Hits 18885 4174 -14711
+ Misses 43975 4206 -39769
+ Partials 1468 291 -1177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Fixes #6801
Does this PR introduce a user-facing change?: