Skip to content

Add missing PingOne Authentication Environment ID option to request command#171

Merged
wesleymccollam merged 3 commits into
mainfrom
addMissingPingOneAuthenticationAPIEnvironmentIDOptionToRequest
May 20, 2026
Merged

Add missing PingOne Authentication Environment ID option to request command#171
wesleymccollam merged 3 commits into
mainfrom
addMissingPingOneAuthenticationAPIEnvironmentIDOptionToRequest

Conversation

@wesleymccollam
Copy link
Copy Markdown
Contributor

@wesleymccollam wesleymccollam commented Apr 23, 2026

Change Description

Add missing PingOne Authentication Environment ID option to request command

CDI-886

Change Characteristics

  • This PR contains beta functionality
  • This PR requires introduction of breaking changes

Checklist

All full (or complete) PRs that need review prior to merge should have the following box checked.

If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked

  • Check to confirm: I have performed a review of my PR against the PR checklist and confirm that:
    • Changes have proper unit and acceptance test coverage (including regression tests)
    • Impacted command, parameter and flag descriptions have been reviewed and updated
    • Impacted command examples have been reviewed and updated
    • Impacted documentation files have been reviewed and updated
    • Does not introduce breaking changes to commands, parameters or flags (unless required to do so)
    • I am aware that changes to generated code may not be merged

Required SDK Upgrades

Testing

This PR has been tested with:

  • Unit tests (please paste commands and results below)
  • Acceptance tests (please paste commands and results below)
  • End-to-end tests (please paste the link to the actions workflow runs)
  • Not applicable (no evidences needed)] Unit tests (please paste commands and results below)
  • Acceptance tests (please paste commands and results below)
  • End-to-end tests (please paste the link to the actions workflow runs)
  • Not applicable (no evidences needed)

Shell Command(s)

go test -v -run 'Test_RequestCommand_HelpIncludesPingOneEnvironmentFlag|Test_RequestCommand_ClientCredentialsEnvironmentErrorUsesSupportedConfigKey' ./cmd/request/... -count=1

Testing Results

Expand Results
=== RUN   Test_RequestCommand_HelpIncludesPingOneEnvironmentFlag
--- PASS: Test_RequestCommand_HelpIncludesPingOneEnvironmentFlag (0.01s)
=== RUN   Test_RequestCommand_ClientCredentialsEnvironmentErrorUsesSupportedConfigKey
--- PASS: Test_RequestCommand_ClientCredentialsEnvironmentErrorUsesSupportedConfigKey (0.00s)
PASS
ok  	github.com/pingidentity/pingcli/cmd/request	0.631s

End-to-end Tests Workflow Links

  • N/A

@wesleymccollam wesleymccollam requested a review from a team as a code owner April 23, 2026 18:54
Comment thread cmd/request/request.go
}

func initPingOneRequestFlags(cmd *cobra.Command) {
cmd.Flags().AddFlag(options.PingOneAuthenticationAPIEnvironmentIDOption.Flag)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this differ from the worker environment ID differ from this arg?

Also how is this used - since I see there are no changes to live code outside of this one line?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The worker environment ID is the fallback value. This is used for auth.

@wesleymccollam wesleymccollam merged commit 8b93d3c into main May 20, 2026
28 of 31 checks passed
@wesleymccollam wesleymccollam deleted the addMissingPingOneAuthenticationAPIEnvironmentIDOptionToRequest branch May 20, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants