Skip to content

fix: include file extensions in client accept filters - #1289

Draft
armancharan wants to merge 1 commit into
pingdotgg:mainfrom
armancharan:fix/accept-mime-extensions
Draft

fix: include file extensions in client accept filters#1289
armancharan wants to merge 1 commit into
pingdotgg:mainfrom
armancharan:fix/accept-mime-extensions

Conversation

@armancharan

Copy link
Copy Markdown

Summary

  • generateMimeTypes and generateClientDropzoneAccept now emit known file extensions alongside MIME types (e.g. .jar for application/java-archive)
  • Fixes #1157: Windows Chrome ignores MIME-only accept values and falls back to "All Files"
  • Adds unit coverage for MIME+extension accept output and the dropzone accept attribute

Test plan

  • bun run --filter @uploadthing/shared test
  • bun run --filter @uploadthing/shared typecheck
  • bun run --filter @uploadthing/shared lint
  • On Windows Chrome: configure a route with 'application/java-archive' and confirm the file picker filters to .jar files

Made with Cursor

Some browsers (Chrome on Windows) ignore MIME-only accept values like
application/java-archive. Emit known extensions from mime-types so the
native file picker can filter correctly.

Co-authored-by: Cursor <cursoragent@cursor.com>
@changeset-bot

changeset-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b38d1f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@uploadthing/shared Patch
@uploadthing/react Patch
@uploadthing/vue Patch
@uploadthing/solid Patch
uploadthing Patch
@uploadthing/expo Patch
@uploadthing/svelte Patch
@uploadthing/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 8, 2026

Copy link
Copy Markdown

@armancharan is attempting to deploy a commit to the Ping Labs Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cc65c0a3-6f98-4bee-833b-f24c71d0f8af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: uploadthing/react - Java-Archive(.jar) file upload type does not show up when choosing files

1 participant