[codex] Preserve cloud disconnect diagnostics#3437
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved This is a self-contained refactor that moves error diagnostics from user-facing console warnings into structured logs. The actual disconnect logic is unchanged, and the new behavior is thoroughly tested. You can customize Macroscope's approvability policy. Learn more. |
Summary
Validation
vp test apps/server/src/cli/connect.test.tsvp checkvp run typecheckNote
Low Risk
CLI-only messaging and logging changes during unlink/logout; no auth or relay protocol changes.
Overview
T3 Connect disconnect no longer prints internal failure text in
Console.warnmessages. Live-server unlink and relay revoke failures still show the same stable guidance, while full Effect causes are recorded viaEffect.logWarningwithoperation,clearAuthorization, andCause.pretty(cause).disconnectClouddelegates user messaging to a new exportedreportCloudDisconnectResults, and live unlink failures now carryCause.Cause<unknown>instead of opaqueunknown. A test asserts private diagnostic strings appear only in structured logs, not in console warnings.Reviewed by Cursor Bugbot for commit 870f4d7. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Preserve cloud disconnect failure causes in structured logs instead of console warnings
reportCloudDisconnectResultsinconnect.tsto separate user-facing console output from detailed failure diagnostics.logCloudDisconnectFailurehelper, rather than interpolated directly into console warnings.disconnectfunction is updated to callreportCloudDisconnectResultsinstead of inlining console logging logic.Macroscope summarized 870f4d7.