[codex] Diagnose desktop client settings read failures

[juliusmarminge]

Desktop client settings intentionally fall back to None when the settings file is missing or unusable, but the loader previously implemented that behavior with Effect.option and Effect.orElseSucceed. Those broad fallbacks also hid permission failures, other filesystem failures, and malformed settings documents without leaving any diagnostic evidence.

This change keeps the existing nonfatal API while making unexpected failures observable. A normalized PlatformError whose reason is NotFound remains an expected silent absence. Other filesystem failures produce a warning annotated with settingsPath and retain the original platform error in the log arguments. Schema failures likewise produce a path-annotated warning with the original SchemaError before returning None. Both recovery points use tagged catch semantics.

The diagnostics tests use an isolated test file because the established client-settings test is currently touched by feature work. They verify that missing files remain silent, permission failures remain nonfatal but observable, and malformed documents remain nonfatal but observable.

Validation:

• vp test apps/desktop/src/settings/DesktopClientSettings.diagnostics.test.ts
• vp check (passes with pre-existing repository warnings only)
• vp run typecheck

---

Note

Low Risk
Behavior for callers (get still returns Option) is unchanged except that some previously hidden failures may now surface as Effect failures or logs; no auth or data-mutation paths.

Overview
Desktop client settings still return None when the file is absent or unusable, but unexpected problems are no longer swallowed silently.

readClientSettings replaces broad Effect.option / orElseSucceed fallbacks with tagged handling: NotFound stays a quiet None; other PlatformError cases emit a warning (with settingsPath) and return None; SchemaError on decode gets the same treatment. Errors outside those tags are no longer converted to None.

Adds DesktopClientSettings.diagnostics.test.ts to assert missing file → no logs, permission/read failure → warning + path, malformed JSON → decode warning + path.

^{Reviewed by Cursor Bugbot for commit 295cff2. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Diagnose desktop client settings read failures with targeted warning logs

• Missing settings files return None silently (no log) in readClientSettings.
• Non-missing filesystem read errors now emit a warning log annotated with settingsPath instead of silently returning None.
• Schema decode failures now emit a warning log annotated with settingsPath instead of silently returning None.
• Read or decode errors that are not PlatformError/SchemaError now propagate as failures rather than being swallowed.
• Adds diagnostic tests in DesktopClientSettings.diagnostics.test.ts covering all three cases above.

^{Macroscope summarized 295cff2.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 01ecb35f-4319-49ef-b2cb-3b957beb2879

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/desktop-client-settings-diagnostics

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds diagnostic warning logs when desktop client settings fail to read due to unexpected errors (not missing file). The actual behavior is unchanged - errors still result in returning None - but now unexpected failures are logged with the settings path for debugging purposes.

No code changes detected at 295cff2. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}