[codex] Structure environment cloud HTTP errors

[juliusmarminge]

Summary

• replace caller-supplied cloud HTTP messages with typed reasons and operations
• derive the existing response messages from structural attributes
• preserve exact internal causes for stack traces while excluding them from encoded HTTP bodies
• expose relay request phase/status diagnostics through the boundary

Tests

• vp test apps/server/src/cloud/http.test.ts
• vp test apps/server/src/server.test.ts
• vp test apps/mobile/src/features/cloud/linkEnvironment.test.ts
• vp check
• vp run typecheck
• vp run lint:mobile

Stacked on #3246.

---

Note

Medium Risk
Touches shared cross-peer HTTP contracts and many T3 Connect cloud paths (link, health, mint, relay); behavior is mostly message shape and logging, with backward-compatible decoding, but mis-encoded errors could affect mobile/relay clients during rollout.

Overview
Environment cloud HTTP errors now use typed reason / operation fields instead of ad-hoc message strings at call sites. In environmentHttp.ts, 400/401/409 responses take enum reasons with derived user-facing messages; 500 responses add operation plus optional relayOperation, relayPhase, and responseStatus for relay failures.

apps/server/src/cloud/http.ts routes all connect handlers through failEnvironmentCloudInternalError, which builds these structured errors, logs operation (and relay context) with causeTag only, and still attaches full cause on the in-process error while encoding omits cause.

Rolling deploy compatibility: optional schema fields and constructors accept legacy message-only JSON on decode; new code must pass structured context.

Tests were updated for cloud_cli_authorization_required, encoded 500 bodies, legacy decode, and relay offline handling with operation.

^{Reviewed by Cursor Bugbot for commit 7d11df3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add structured reason and operation codes to cloud environment HTTP errors

• Introduces enums for bad request reasons, unauthorized reasons, conflict reasons, internal operation codes, and relay operation/phase in environmentHttp.ts, replacing free-form message strings with structured fields.
• Updates all cloud HTTP error classes (EnvironmentHttpBadRequestError, EnvironmentHttpUnauthorizedError, EnvironmentHttpConflictError, EnvironmentHttpInternalServerError, etc.) to derive standardized messages from reason/operation codes while preserving legacy message-only decoding for rolling deployments.
• Refactors all handlers and utilities in http.ts to construct errors with typed reason or operation fields instead of inline message strings.
• Behavioral Change: Clients parsing error bodies will now see additional structured fields (reason, operation, relayOperation, relayPhase) alongside messages; legacy message-only payloads are still decoded correctly.

^{Macroscope summarized 7d11df3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b3bbb87c-2fad-4432-8f59-90d640e1c540

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-environment-http-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors HTTP error handling to use typed reason codes instead of free-form message strings, with messages derived from lookup tables. The actual error behavior and messages remain unchanged, with backward-compatible decoding for rolling deployments.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 744a307

Dismissing prior approval to re-evaluate 1e09188

Dismissing prior approval to re-evaluate 73fb3f6

Dismissing prior approval to re-evaluate 7d11df3