-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[codex] Preserve terminal preview link failure context #3367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
2
commits into
main
Choose a base branch
from
codex/terminal-preview-link-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
130 changes: 130 additions & 0 deletions
130
apps/web/src/components/preview/openTerminalLinkInPreview.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| import type { LocalApi, PreviewSessionSnapshot, ScopedThreadRef } from "@t3tools/contracts"; | ||
| import * as Cause from "effect/Cause"; | ||
| import { AsyncResult } from "effect/unstable/reactivity"; | ||
| import { afterEach, describe, expect, it, vi } from "vite-plus/test"; | ||
|
|
||
| import { | ||
| openTerminalLinkInPreview, | ||
| TerminalLinkContextMenuShowError, | ||
| TerminalLinkPreviewOpenError, | ||
| } from "./openTerminalLinkInPreview"; | ||
|
|
||
| vi.mock("~/previewStateStore", () => ({ | ||
| applyPreviewServerSnapshot: vi.fn(), | ||
| isPreviewSupportedInRuntime: () => true, | ||
| })); | ||
|
|
||
| vi.mock("~/rightPanelStore", () => ({ | ||
| useRightPanelStore: { | ||
| getState: () => ({ openBrowser: vi.fn() }), | ||
| }, | ||
| })); | ||
|
|
||
| const threadRef = { | ||
| environmentId: "local" as ScopedThreadRef["environmentId"], | ||
| threadId: "thread-1" as ScopedThreadRef["threadId"], | ||
| }; | ||
|
|
||
| const snapshot: PreviewSessionSnapshot = { | ||
| threadId: threadRef.threadId, | ||
| tabId: "tab-1", | ||
| navStatus: { _tag: "Idle" }, | ||
| canGoBack: false, | ||
| canGoForward: false, | ||
| updatedAt: "2026-06-20T00:00:00.000Z", | ||
| }; | ||
|
|
||
| afterEach(() => { | ||
| vi.restoreAllMocks(); | ||
| }); | ||
|
|
||
| describe("openTerminalLinkInPreview", () => { | ||
| it("preserves context-menu failures with terminal link context before falling back", async () => { | ||
| const cause = new Error("menu unavailable"); | ||
| const fallbackToBrowser = vi.fn(); | ||
| const openPreview = vi.fn(async () => AsyncResult.success(snapshot)); | ||
| const reportError = vi.spyOn(console, "error").mockImplementation(() => undefined); | ||
|
|
||
| await openTerminalLinkInPreview({ | ||
| url: "http://localhost:3000/path?token=secret", | ||
| position: { x: 12, y: 34 }, | ||
| threadRef, | ||
| openPreview, | ||
| localApi: { | ||
| contextMenu: { | ||
| show: vi.fn(async () => { | ||
| throw cause; | ||
| }), | ||
| }, | ||
| } as unknown as LocalApi, | ||
| fallbackToBrowser, | ||
| }); | ||
|
|
||
| expect(fallbackToBrowser).toHaveBeenCalledOnce(); | ||
| expect(openPreview).not.toHaveBeenCalled(); | ||
| expect(reportError).toHaveBeenCalledOnce(); | ||
| const error = reportError.mock.calls[0]?.[0]; | ||
| expect(error).toBeInstanceOf(TerminalLinkContextMenuShowError); | ||
| expect(error).toMatchObject({ | ||
| environmentId: "local", | ||
| threadId: "thread-1", | ||
| targetOrigin: "http://localhost:3000", | ||
| cause, | ||
| }); | ||
| expect(error.message).not.toContain("menu unavailable"); | ||
| expect(error.targetOrigin).not.toContain("secret"); | ||
| }); | ||
|
|
||
| it("preserves the complete preview failure cause before falling back", async () => { | ||
| const rpcError = new Error("preview unavailable"); | ||
| const cause = Cause.combine(Cause.fail(rpcError), Cause.die("preview defect")); | ||
| const fallbackToBrowser = vi.fn(); | ||
| const reportError = vi.spyOn(console, "error").mockImplementation(() => undefined); | ||
|
|
||
| await openTerminalLinkInPreview({ | ||
| url: "http://127.0.0.1:5173/", | ||
| position: { x: 12, y: 34 }, | ||
| threadRef, | ||
| openPreview: async () => AsyncResult.failure(cause), | ||
| localApi: { | ||
| contextMenu: { | ||
| show: vi.fn(async () => "open-in-preview"), | ||
| }, | ||
| } as unknown as LocalApi, | ||
| fallbackToBrowser, | ||
| }); | ||
|
|
||
| expect(fallbackToBrowser).toHaveBeenCalledOnce(); | ||
| expect(reportError).toHaveBeenCalledOnce(); | ||
| const error = reportError.mock.calls[0]?.[0]; | ||
| expect(error).toBeInstanceOf(TerminalLinkPreviewOpenError); | ||
| expect(error).toMatchObject({ | ||
| environmentId: "local", | ||
| threadId: "thread-1", | ||
| targetOrigin: "http://127.0.0.1:5173", | ||
| cause, | ||
| }); | ||
| expect(error.message).not.toContain("preview unavailable"); | ||
| }); | ||
|
|
||
| it("does not report or fall back when opening the preview is interrupted", async () => { | ||
| const fallbackToBrowser = vi.fn(); | ||
| const reportError = vi.spyOn(console, "error").mockImplementation(() => undefined); | ||
|
|
||
| await openTerminalLinkInPreview({ | ||
| url: "http://localhost:5173/", | ||
| position: { x: 12, y: 34 }, | ||
| threadRef, | ||
| openPreview: async () => AsyncResult.failure(Cause.interrupt()), | ||
| localApi: { | ||
| contextMenu: { | ||
| show: vi.fn(async () => "open-in-preview"), | ||
| }, | ||
| } as unknown as LocalApi, | ||
| fallbackToBrowser, | ||
| }); | ||
|
|
||
| expect(reportError).not.toHaveBeenCalled(); | ||
| expect(fallbackToBrowser).not.toHaveBeenCalled(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.