Skip to content

[codex] Structure relay install confirmation conflicts#3365

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/relay-install-dialog-error
Jun 20, 2026
Merged

[codex] Structure relay install confirmation conflicts#3365
juliusmarminge merged 1 commit into
mainfrom
codex/relay-install-dialog-error

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jun 20, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the concurrent relay install confirmation Error with a Schema tagged error
  • capture requested and active versions plus dialog lifecycle and install stage
  • keep the state conflict cause-free instead of inventing a synthetic cause

Verification

  • vp test apps/web/src/cloud/relayClientInstallDialog.test.ts
  • vp check (passes with existing warnings)
  • vp run typecheck

Overlap audit

  • gh pr list --limit 1000 found no other open PR touching either changed file

Note

Low Risk
Localized dialog-coordinator error typing and messaging; callers that only checked generic Error messages may need to handle the new class.

Overview
Concurrent relay client install confirmation requests now reject with RelayClientInstallConfirmationConflictError (Effect Schema tagged error) instead of a generic Error.

The rejection carries requested vs active version, dialog status (confirming / installing / closing), and install stage when the active flow is installing; closing still resolves the active version from the nested view. A coordinator test asserts the structured fields and that the error has no cause.

Reviewed by Cursor Bugbot for commit 8d4fce9. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace generic Error with structured RelayClientInstallConfirmationConflictError for install conflicts

When requestRelayClientInstallConfirmation is called while the dialog is not idle, it now rejects with a new RelayClientInstallConfirmationConflictError instead of a generic Error. The structured error carries requestedVersion, activeVersion, activeDialogStatus, and optionally activeInstallStage, giving callers enough detail to handle conflicts programmatically.

Macroscope summarized 8d4fce9.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d135a76b-849b-4713-bcda-1b4d68ca1ed1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/relay-install-dialog-error

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 20, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This change replaces a generic error with a structured error class for relay client install confirmation conflicts. The control flow is unchanged - only the error reporting is improved with additional context fields. Low risk, self-contained refactor.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit 8112aff into main Jun 20, 2026
16 checks passed
@juliusmarminge juliusmarminge deleted the codex/relay-install-dialog-error branch June 20, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant