[codex] Structure relay install confirmation conflicts#3365
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved This change replaces a generic error with a structured error class for relay client install confirmation conflicts. The control flow is unchanged - only the error reporting is improved with additional context fields. Low risk, self-contained refactor. You can customize Macroscope's approvability policy. Learn more. |
Summary
Errorwith a Schema tagged errorVerification
vp test apps/web/src/cloud/relayClientInstallDialog.test.tsvp check(passes with existing warnings)vp run typecheckOverlap audit
gh pr list --limit 1000found no other open PR touching either changed fileNote
Low Risk
Localized dialog-coordinator error typing and messaging; callers that only checked generic Error messages may need to handle the new class.
Overview
Concurrent relay client install confirmation requests now reject with
RelayClientInstallConfirmationConflictError(Effect Schema tagged error) instead of a genericError.The rejection carries requested vs active version, dialog status (
confirming/installing/closing), and install stage when the active flow is installing;closingstill resolves the active version from the nested view. A coordinator test asserts the structured fields and that the error has nocause.Reviewed by Cursor Bugbot for commit 8d4fce9. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Replace generic Error with structured
RelayClientInstallConfirmationConflictErrorfor install conflictsWhen
requestRelayClientInstallConfirmationis called while the dialog is not idle, it now rejects with a newRelayClientInstallConfirmationConflictErrorinstead of a genericError. The structured error carriesrequestedVersion,activeVersion,activeDialogStatus, and optionallyactiveInstallStage, giving callers enough detail to handle conflicts programmatically.Macroscope summarized 8d4fce9.