Skip to content

[codex] Report markdown interaction failures#3355

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/web-markdown-action-errors
Jun 20, 2026
Merged

[codex] Report markdown interaction failures#3355
juliusmarminge merged 1 commit into
mainfrom
codex/web-markdown-action-errors

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jun 20, 2026

Copy link
Copy Markdown
Member

Summary

  • report table and code clipboard failures with format/language context without logging copied content
  • preserve exact causes and target paths for file open, path-copy, and context-menu failures
  • distinguish link context-menu, integrated-preview, and external-browser operations while leaving cancellation and UI fallbacks unchanged

Verification

  • vp check
  • vp run typecheck

Note

Low Risk
Observability and error-handling only in chat markdown UI; success paths, cancellation handling, and user-facing toasts are preserved.

Overview
Adds reportMarkdownActionFailure in ChatMarkdown.tsx to log [chat-markdown] action failed with an operation label and contextual fields (paths, copy format, code language/fence title) while not logging clipboard payload content.

Clipboard: Table and code-block copy handlers no longer swallow errors; failures are logged with copy-table / copy-code-block context. File path copy failures also log copy-file-path before showing the existing error toast.

File links: Open-in-editor and open-in-browser flows wrap async work in try/catch, log failures with the target path, and still show the same error toasts; interrupted commands are unchanged. File link context menu errors are logged instead of failing silently.

External links: Link context menu handling is refactored to async/try/catch, with distinct operations for showing the menu, opening in integrated preview (logging only on real Failure, not interruption), and opening in the system browser.

Reviewed by Cursor Bugbot for commit ac14e35. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Report markdown interaction failures in chat with error logging and toasts

  • Adds reportMarkdownActionFailure helper in ChatMarkdown.tsx that logs failures via console.error with a standardized prefix and context.
  • Replaces silent catch blocks in MarkdownTable and MarkdownCodeBlock with calls to the new helper, so clipboard copy failures are now logged with operation context.
  • MarkdownFileLink now wraps file open and copy operations in try/catch, reports failures via the helper, and shows error toasts on thrown errors.
  • The external link context menu in ChatMarkdown now reports failures for menu display, preview opens, and external link opens instead of silently swallowing errors.

Macroscope summarized ac14e35.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 42189a4c-e492-4259-8fb7-52b6fd519e45

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/web-markdown-action-errors

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jun 20, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This PR adds console error logging for markdown interaction failures for debugging purposes. The changes replace silent error swallowing with structured error reporting while preserving all existing user-facing behavior (toasts, error handling). This is a low-risk observability improvement.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit aab72f1 into main Jun 20, 2026
16 checks passed
@juliusmarminge juliusmarminge deleted the codex/web-markdown-action-errors branch June 20, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant