[codex] align relay agent activity Effect services

[juliusmarminge]

Summary

• Inlines the relay agent-activity service contracts on their Context.Service tags and replaces standalone shape references with Service["Service"].
• Uses namespace imports and module-qualified access for local service modules throughout the changed files.
• Preserves the existing effectful make values and canonical layer exports without synthetic Effect.succeed wrappers.
• Keeps the APNs queue adapter implementation-specific as layerCloudflareQueues.
• Replaces free-form APNs invalid-job message data with a structured finite reason; the human-readable message is derived from that reason.

Behavior

Delivery, persistence, queueing, and APNs request behavior are unchanged. The invalid-job error payload is more structured while retaining the existing messages through its getter.

Validation

• vp test src/agentActivity from infra/relay — 8 files / 50 tests passed
• vp check — passed; 20 pre-existing unrelated warnings
• vp run typecheck — passed
• git diff --check origin/main...HEAD — passed
• Stale shape and named service-consumer audits — no violations
• Refactor-only test audit — no test declarations or assertions added
• Orchestration/MCP diff audit — no changes
• Review-thread audit — no unresolved threads

---

Note

Low Risk
Mostly structural typing and imports; the only behavioral API shift is ApnsDeliveryJobInvalid exposing reason instead of a stored message field—callers that relied on serialized error data should use reason.

Overview
Refactors relay agent-activity modules to match the repo’s Effect Context.Service pattern: standalone *Shape interfaces are removed and service contracts are inlined on each service class. Call sites and tests now type mocks and implementations via SomeService["Service"] instead of SomeServiceShape.

ApnsClient switches to submodule imports for effect/unstable/http (Headers, HttpClient, HttpClientRequest) and uses type-only config import; implementation typing references ApnsClient["Service"].

ApnsDeliveryJobInvalid no longer stores a free-text message field. It carries a finite reason code (e.g. invalid-queue-payload, invalid-signature, missing-live-activity-aggregate); human-readable text is unchanged via a message getter mapped from reason. Validation and processSignedJob paths construct errors with reason codes.

Minor import/style updates: Function.cast via effect/Function namespace in persistence modules. No intended change to publish/deliver/register runtime behavior beyond the error payload shape for invalid queue jobs.

^{Reviewed by Cursor Bugbot for commit 878c7d7. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Refactor relay agent activity services to inline Context.Service types and add reason codes to ApnsDeliveryJobInvalid

• Removes separate *Shape interfaces from all agent activity services (ApnsClient, ApnsDeliveries, LiveActivities, AgentActivityRows, Devices, etc.) and inlines the service shape directly into the Context.Service generic, aligning with the Effect service pattern used elsewhere in the relay.
• Redefines ApnsDeliveryJobInvalid in apnsDeliveryJobs.ts to carry a reason field with specific literal codes (e.g. 'missing-live-activity-aggregate', 'invalid-signature') instead of a raw message field; message is now derived via a getter.
• Updates validatePayloadShape and verifySignedApnsDeliveryJob to construct ApnsDeliveryJobInvalid with the new reason codes.
• Behavioral Change: ApnsDeliveryJobInvalid error objects now expose a structured reason code for programmatic inspection; callers reading .message from the schema field will need to use the getter instead.

^{Macroscope summarized 878c7d7.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f6752d20-0f97-4da7-ae3a-50207663e4ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/effect-service-relay-agent-activity

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Expo continuous deployment is ready!

• Project → t3-code
• Platforms → android, ios
• Scheme → t3code-preview

	🤖 Android	🍎 iOS
Fingerprint	fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea	ae3bd597809dfd7771d0898f735d172973d4c1c8
Build Details	Build Permalink Details Distribution: INTERNAL Build profile: preview:dev Runtime version: fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea App version: 0.1.0 Git commit: f30c72047f910d3c63edf84887f4c6392d72a650	Build Permalink Details Distribution: INTERNAL Build profile: preview:dev Runtime version: ae3bd597809dfd7771d0898f735d172973d4c1c8 App version: 0.1.0 Git commit: eb448c5d21d67cc2c283172b1ea3495232588935
Update Details	Update Permalink Details Branch: pr-3179 Runtime version: fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea Git commit: f30c72047f910d3c63edf84887f4c6392d72a650	Update Permalink Details Branch: pr-3179 Runtime version: ae3bd597809dfd7771d0898f735d172973d4c1c8 Git commit: f30c72047f910d3c63edf84887f4c6392d72a650
Update QR

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactoring that reorganizes Effect service type definitions by inlining *Shape interfaces into the class generic parameter. All method signatures are preserved, and the error reason change maintains identical messages via a getter. No runtime behavior impact.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate c24202d

Dismissing prior approval to re-evaluate 878c7d7