Feature/intellij editors#2475
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: Turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. 👉 Get your free trial and get 200 agent minutes per Slack user (a $50 value). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6da216c. Configure here.
ApprovabilityVerdict: Approved Adds 11 JetBrains IDE options to the existing editor picker by extending arrays and adding SVG icon components. Changes follow established patterns, are well-tested, and don't introduce new workflows or capabilities beyond the existing editor selection feature. You can customize Macroscope's approvability policy. Learn more. |
6da216c to
361299e
Compare
361299e to
d1adf2b
Compare
Dismissing prior approval to re-evaluate d1adf2b
…egression (to be verified by @julius)
Dismissing prior approval to re-evaluate 8463a85

What Changed
Why
UI Changes
editor selector

file outside of the project

external link renders as expected

before and after for file links
Checklist
Note
Medium Risk
Moderate risk: expands editor/command resolution and changes markdown file-link parsing/rewriting (including Windows path handling), which could regress link rendering or editor launching across platforms.
Overview
JetBrains IDE support: adds 11 JetBrains editors (e.g.
aqua,clion,pycharm,webstorm) topackages/contracts/src/editor.ts, exposes them in the webOpenInPicker, and extends server-side editor launch/availability tests to cover their commands andline-columnnavigation args.Markdown file-link fixes: improves
markdown-linkshandling by normalizing markdown link destinations (trim + unwrap<...>), correctly stripping leading/from Windows drive paths, and updating ChatMarkdown link rewriting so#LxCyanchors become:line[:col]editor targets; corresponding browser/unit tests were updated.Reviewed by Cursor Bugbot for commit 8463a85. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add support for 11 additional JetBrains editors in the editor picker
editor.ts, each usingline-columnlaunch style.JetBrainsIcons.tsxmodule and wires them into theOpenInPicker.markdown-links.ts: angle-bracketed hrefs are now unwrapped, Windows drive paths with a leading slash are normalized, and file URI hrefs produce colon-separated line/column positions.file:1:7) instead of hash anchors (e.g.file#L1C7).Macroscope summarized 8463a85.