feat: ios16 support#2469
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR updates a vendored native iOS library (GhosttyKit) with iOS 16 compatibility patches. Vendored binary updates cannot be fully verified through code review alone, and this enables new platform support, warranting human review. No code changes detected at You can customize Macroscope's approvability policy. Learn more. |
842c2d5 to
96897ab
Compare
What Changed
Adds ios 16 support to the GhosttyKit library used in mobile app
Why
So we support ios 16
Checklist
Note
Medium Risk
Updates the vendored native
GhosttyKit.xcframeworkand its C API surface, which can affect terminal rendering/input behavior on iOS at runtime. Risk is mitigated by minimal Swift-side changes (signature alignment) and added rebuild documentation/script for repeatability.Overview
Adds iOS 16 support for the mobile terminal by updating the vendored
GhosttyKit.xcframeworkto a new custom-I/O fork/revision and refreshing the shipped headers (ghostty.h) andVendor/libghostty/VERSION.Aligns
T3TerminalView.swiftwith the updated Ghostty runtime callback signature (read_clipboard_cbnow returnsbool) and documents/reprovisions the vendor build via a newscripts/build-libghostty-ios16.shplus README/third-party notice updates.Separately pins
shikito3.23.0inapps/mobile/package.json(and lockfile) to avoid dependency conflicts with packages expecting differentshikimajor versions.Reviewed by Cursor Bugbot for commit 40cc9c5. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add iOS 16 support to the mobile terminal using a custom Ghostty fork
GhosttyKit.xcframeworkto a custom-I/O fork of Ghostty with an iOS 16 compatibility patch (revisiond36c3b8).build-libghostty-ios16.sh, a script to rebuild the xcframework from source using Zig 0.15.2, replacing only theios-arm64andios-arm64-simulatorslices.T3TerminalView.swiftto returnfalsefrom theread_clipboard_cbclosure to match the updatedghostty_runtime_read_clipboard_cbsignature (changed fromvoidtobool).shiki@3.23.0as a dependency and updates the lockfile with scoped resolutions to avoid conflicts with packages expectingshiki@4.x.Macroscope summarized 40cc9c5.