Skip to content

*: upgrade go to 1.25.10#1113

Merged
djshow832 merged 6 commits into
pingcap:release-1.3from
djshow832:upgrade_go
Jun 1, 2026
Merged

*: upgrade go to 1.25.10#1113
djshow832 merged 6 commits into
pingcap:release-1.3from
djshow832:upgrade_go

Conversation

@djshow832
Copy link
Copy Markdown
Collaborator

@djshow832 djshow832 commented Mar 27, 2026

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
Upgrade go because of EE requirement.

What is changed and how it works:
Upgrade go and fix lint.
verifyPeerCertificates is updated because VerifyConnection also verifies resumed sessions, and ConnectionState.PeerCertificates is already parsed and can be reused.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 27, 2026

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot requested review from bb7133 and xhebox March 27, 2026 08:09
@ti-chi-bot ti-chi-bot Bot added the size/L label Mar 27, 2026
@djshow832 djshow832 changed the title *: upgrade go to 1.25.8 *: upgrade go to 1.25.10 Jun 1, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.3@6b80686). Learn more about missing BASE report.

Files with missing lines Patch % Lines
lib/cli/util.go 0.00% 3 Missing ⚠️
pkg/proxy/net/packetio.go 33.33% 0 Missing and 2 partials ⚠️
lib/config/proxy.go 0.00% 1 Missing ⚠️
pkg/balance/router/router.go 0.00% 1 Missing ⚠️
pkg/proxy/net/proxy.go 50.00% 0 Missing and 1 partial ⚠️
pkg/util/lex/lex.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.3    #1113   +/-   ##
==============================================
  Coverage               ?   65.55%           
==============================================
  Files                  ?      125           
  Lines                  ?    12313           
  Branches               ?        0           
==============================================
  Hits                   ?     8072           
  Misses                 ?     3700           
  Partials               ?      541           
Flag Coverage Δ
unit 65.55% <76.92%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Jun 1, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 1, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-06-01 09:18:18.444507775 +0000 UTC m=+173999.514825155: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 1, 2026
Copy link
Copy Markdown
Collaborator Author

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 1, 2026

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@djshow832 djshow832 merged commit 2d526f4 into pingcap:release-1.3 Jun 1, 2026
5 of 6 checks passed
@djshow832 djshow832 deleted the upgrade_go branch June 1, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants