statistics: remove unused global singleton estimator - #70928
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change removes global singleton estimation from Changes
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes an unused estimator and its associated tests and build metadata while leaving NDV estimation unchanged. No concrete current-head merge risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads each line, Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #70928 +/- ##
================================================
- Coverage 76.3212% 72.9336% -3.3876%
================================================
Files 2041 2109 +68
Lines 556443 599132 +42689
================================================
+ Hits 424684 436969 +12285
- Misses 130859 160280 +29421
- Partials 900 1883 +983
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/hold |
d2afdda to
3bf7d8c
Compare
0xPoe
left a comment
There was a problem hiding this comment.
🔢 Self-check (PR reviewed by myself and ready for feedback)
-
Code compiles successfully
-
Unit tests added
-
No AI-generated elegant nonsense in PR.
-
Comments added where necessary
-
PR title and description updated
-
Documentation PR created (or confirmed not needed)
-
PR size is reasonable
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjonss, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/retest |
What problem does this PR solve?
Issue Number: ref #67449
Problem Summary:
EstimateGlobalSingletonBySketcheshas no production callers.What changed and how does it work?
Remove the unused estimator, its private helpers and dedicated tests; regenerate Bazel metadata. Keep NDV estimation unchanged.
Check List
Tests
Validation (Ready profile; failpoints enabled and cleaned up):
make bazel_prepare ./tools/check/failpoint-go-test.sh pkg/statistics -run '^TestEstimateNDVByGEE$' -count=1 make lint git diff --checkSide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit
Removed
Tests